From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 2/2] ui: tasks: use autoshow instead of win.show
Date: Mon, 11 Nov 2024 16:50:43 +0100 [thread overview]
Message-ID: <20241111155043.369360-3-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20241111155043.369360-1-a.lauterer@proxmox.com>
This is the current approach to create new windows and will align it to
the other handler (action column).
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
no changes since v1
www/manager6/dc/Tasks.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js
index 4b542762..24b2697f 100644
--- a/www/manager6/dc/Tasks.js
+++ b/www/manager6/dc/Tasks.js
@@ -42,11 +42,11 @@ Ext.define('PVE.dc.Tasks', {
return;
}
- var win = Ext.create('Proxmox.window.TaskViewer', {
+ Ext.create('Proxmox.window.TaskViewer', {
+ autoShow: true,
upid: rec.data.upid,
endtime: rec.data.endtime,
});
- win.show();
};
Ext.apply(me, {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-11 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 15:50 [pve-devel] [PATCH manager v2 0/2] ui: tasks: add button to open task Aaron Lauterer
2024-11-11 15:50 ` [pve-devel] [PATCH manager v2 1/2] ui: tasks: add actioncolumn " Aaron Lauterer
2024-11-11 15:50 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111155043.369360-3-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox