public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority
@ 2024-11-11 10:08 Aaron Lauterer
  2024-11-11 10:08 ` [pve-devel] [PATCH ha-manager 2/2] tools: adapt line lengths of verbose descriptions Aaron Lauterer
  2024-11-11 20:31 ` [pve-devel] applied: [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Aaron Lauterer @ 2024-11-11 10:08 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/PVE/HA/Tools.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/HA/Tools.pm b/src/PVE/HA/Tools.pm
index edd5642..09b73f1 100644
--- a/src/PVE/HA/Tools.pm
+++ b/src/PVE/HA/Tools.pm
@@ -75,7 +75,7 @@ sub pve_verify_ha_group_node {
 
 PVE::JSONSchema::register_standard_option('pve-ha-group-node-list', {
     description => "List of cluster node names with optional priority.",
-    verbose_description => "List of cluster node members, where a priority can be given to each node. A resource bound to a group will run on the available nodes with the highest priority. If there are more nodes in the highest priority class, the services will get distributed to those nodes. The priorities have a relative meaning only.",
+    verbose_description => "List of cluster node members, where a priority can be given to each node. A resource bound to a group will run on the available nodes with the highest priority. If there are more nodes in the highest priority class, the services will get distributed to those nodes. The priorities have a relative meaning only. The higher the number, the higher the priority.",
     type => 'string', format => 'pve-ha-group-node-list',
     typetext => '<node>[:<pri>]{,<node>[:<pri>]}*',
 });
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] [PATCH ha-manager 2/2] tools: adapt line lengths of verbose descriptions
  2024-11-11 10:08 [pve-devel] [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority Aaron Lauterer
@ 2024-11-11 10:08 ` Aaron Lauterer
  2024-11-11 20:31 ` [pve-devel] applied: [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Aaron Lauterer @ 2024-11-11 10:08 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/PVE/HA/Tools.pm | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/PVE/HA/Tools.pm b/src/PVE/HA/Tools.pm
index 09b73f1..0f9e9a5 100644
--- a/src/PVE/HA/Tools.pm
+++ b/src/PVE/HA/Tools.pm
@@ -40,7 +40,8 @@ sub pve_verify_ha_resource_id {
 }
 
 PVE::JSONSchema::register_standard_option('pve-ha-resource-id', {
-    description => "HA resource ID. This consists of a resource type followed by a resource specific name, separated with colon (example: vm:100 / ct:100).",
+    description => "HA resource ID. This consists of a resource type followed by a resource"
+	." specific name, separated with colon (example: vm:100 / ct:100).",
     typetext => "<type>:<name>",
     type => 'string', format => 'pve-ha-resource-id',
 });
@@ -57,7 +58,9 @@ sub pve_verify_ha_resource_or_vm_id {
 }
 
 PVE::JSONSchema::register_standard_option('pve-ha-resource-or-vm-id', {
-    description => "HA resource ID. This consists of a resource type followed by a resource specific name, separated with colon (example: vm:100 / ct:100). For virtual machines and containers, you can simply use the VM or CT id as a shortcut (example: 100).",
+    description => "HA resource ID. This consists of a resource type followed by a resource"
+	." specific name, separated with colon (example: vm:100 / ct:100). For virtual machines and"
+	." containers, you can simply use the VM or CT id as a shortcut (example: 100).",
     typetext => "<type>:<name>",
     type => 'string', format => 'pve-ha-resource-or-vm-id',
 });
@@ -75,7 +78,11 @@ sub pve_verify_ha_group_node {
 
 PVE::JSONSchema::register_standard_option('pve-ha-group-node-list', {
     description => "List of cluster node names with optional priority.",
-    verbose_description => "List of cluster node members, where a priority can be given to each node. A resource bound to a group will run on the available nodes with the highest priority. If there are more nodes in the highest priority class, the services will get distributed to those nodes. The priorities have a relative meaning only. The higher the number, the higher the priority.",
+    verbose_description => "List of cluster node members, where a priority can be given to each"
+	." node. A resource bound to a group will run on the available nodes with the highest"
+	." priority. If there are more nodes in the highest priority class, the services will get"
+	." distributed to those nodes. The priorities have a relative meaning only. The higher the"
+	." number, the higher the priority.",
     type => 'string', format => 'pve-ha-group-node-list',
     typetext => '<node>[:<pri>]{,<node>[:<pri>]}*',
 });
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority
  2024-11-11 10:08 [pve-devel] [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority Aaron Lauterer
  2024-11-11 10:08 ` [pve-devel] [PATCH ha-manager 2/2] tools: adapt line lengths of verbose descriptions Aaron Lauterer
@ 2024-11-11 20:31 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-11-11 20:31 UTC (permalink / raw)
  To: Proxmox VE development discussion, Aaron Lauterer

Am 11.11.24 um 11:08 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  src/PVE/HA/Tools.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied both patches, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-11 20:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-11 10:08 [pve-devel] [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority Aaron Lauterer
2024-11-11 10:08 ` [pve-devel] [PATCH ha-manager 2/2] tools: adapt line lengths of verbose descriptions Aaron Lauterer
2024-11-11 20:31 ` [pve-devel] applied: [PATCH ha-manager 1/2] tools: group verbose desc: mention higher number is higher priority Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal