From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v3 1/1] pci: don't hard require resetting devices for passthrough
Date: Mon, 11 Nov 2024 09:12:28 +0100 [thread overview]
Message-ID: <20241111081228.375675-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20241111081228.375675-1-d.csapak@proxmox.com>
Since pve-common commit:
eff5957 (sysfstools: file_write: properly catch errors)
this check here fails now when the reset does not work. It turns out
that resetting the device is not always necessary, and we previously
ignored most errors when trying to do so.
To restore that functionality, downgrade this `die` to a warning.
If the device really needs a reset to work, it will either fail later
during startup, or not work correctly in the guest, but that behavior
existed before and is AFAIK not really detectable from our side.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
no changes from v2
PVE/QemuServer/PCI.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index 75eac134..dceb8938 100644
--- a/PVE/QemuServer/PCI.pm
+++ b/PVE/QemuServer/PCI.pm
@@ -728,7 +728,7 @@ sub prepare_pci_device {
} else {
die "can't unbind/bind PCI group to VFIO '$pciid'\n"
if !PVE::SysFSTools::pci_dev_group_bind_to_vfio($pciid);
- die "can't reset PCI device '$pciid'\n"
+ warn "can't reset PCI device '$pciid'\n"
if $info->{has_fl_reset} && !PVE::SysFSTools::pci_dev_reset($info);
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-11 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 8:12 [pve-devel] [PATCH common/qemu-server v3] improve sysfs write behaviour Dominik Csapak
2024-11-11 8:12 ` [pve-devel] [PATCH common v3 1/2] sysfstools: file_write: extend with logging and ignore list Dominik Csapak
2024-11-11 9:02 ` Thomas Lamprecht
2024-11-11 8:12 ` [pve-devel] [PATCH common v3 2/2] sysfstools: fix regression on binding to vfio-pci Dominik Csapak
2024-11-11 8:12 ` Dominik Csapak [this message]
2024-11-11 9:05 ` [pve-devel] [PATCH qemu-server v3 1/1] pci: don't hard require resetting devices for passthrough Thomas Lamprecht
2024-11-11 10:20 ` [pve-devel] [PATCH common/qemu-server v3] improve sysfs write behaviour Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111081228.375675-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox