From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common/qemu-server v3] improve sysfs write behaviour
Date: Mon, 11 Nov 2024 09:12:25 +0100 [thread overview]
Message-ID: <20241111081228.375675-1-d.csapak@proxmox.com> (raw)
and fix passthrough regressions
As i feared previously in [0], making it a hard error when encountering
errors during sysfs writes uncovered some situations where our code was
too strict to keep some setups working.
One such case is resetting devices, which is seemingly not necessary
at all times, so this series
* donwgrades that error to warning
* adds some more logging to `file_write` to be able to better debug
Another case that broke was passing through similar devices with the
same vendor/modelid since the write to vfio-pci's 'new_id' works only
once for the same vendor/modelid.
To fix that make some errors ignorable for file_write
changes from v2:
* improve comment on file_write
* shorten code with suggestions from stoiko
* fix commit message
changes from v1:
* also include error ignore list
* ignore EEXIST for writing to new_id
0: https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csapak@proxmox.com/
pve-common:
Dominik Csapak (2):
sysfstools: file_write: extend with logging and ignore list
sysfstools: fix regression on binding to vfio-pci
src/PVE/SysFSTools.pm | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
qemu-server:
Dominik Csapak (1):
pci: don't hard require resetting devices for passthrough
PVE/QemuServer/PCI.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-11 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 8:12 Dominik Csapak [this message]
2024-11-11 8:12 ` [pve-devel] [PATCH common v3 1/2] sysfstools: file_write: extend with logging and ignore list Dominik Csapak
2024-11-11 9:02 ` Thomas Lamprecht
2024-11-11 8:12 ` [pve-devel] [PATCH common v3 2/2] sysfstools: fix regression on binding to vfio-pci Dominik Csapak
2024-11-11 8:12 ` [pve-devel] [PATCH qemu-server v3 1/1] pci: don't hard require resetting devices for passthrough Dominik Csapak
2024-11-11 9:05 ` Thomas Lamprecht
2024-11-11 10:20 ` [pve-devel] [PATCH common/qemu-server v3] improve sysfs write behaviour Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111081228.375675-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox