From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit v2] node/ServiceView: fix #5611: hiding the non-installed services
Date: Mon, 11 Nov 2024 08:58:11 +0100 [thread overview]
Message-ID: <20241111075811.5008-1-d.herzig@proxmox.com> (raw)
This patch adds a filter to identify services, which are reported as
'not-found' by the api. By default they will not be shown in the UI
anymore, but visibility can still be toggled using a new checkbox.
Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
changes since v1:
* applied Thomas' suggestions:
** use camelCase for filtername.
** invert default preselection logic and corresponding UI labelling.
src/node/ServiceView.js | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js
index 19cfc18..5c6333b 100644
--- a/src/node/ServiceView.js
+++ b/src/node/ServiceView.js
@@ -29,6 +29,8 @@ Ext.define('Proxmox.node.ServiceView', {
},
});
+ let filterInstalledOnly = record => record.get('unit-state') !== 'not-found';
+
let store = Ext.create('Proxmox.data.DiffStore', {
rstore: rstore,
sortAfterUpdate: true,
@@ -38,6 +40,24 @@ Ext.define('Proxmox.node.ServiceView', {
direction: 'ASC',
},
],
+ filters: [
+ filterInstalledOnly,
+ ],
+ });
+
+ let unHideCB = Ext.create('Ext.form.field.Checkbox', {
+ boxLabel: gettext('Show only installed services'),
+ value: true,
+ boxLabelAlign: 'before',
+ listeners: {
+ change: function(_cb, value) {
+ if (value) {
+ store.addFilter([filterInstalledOnly]);
+ } else {
+ store.clearFilter();
+ }
+ },
+ },
});
let view_service_log = function() {
@@ -166,6 +186,8 @@ Ext.define('Proxmox.node.ServiceView', {
restart_btn,
'-',
syslog_btn,
+ '->',
+ unHideCB,
],
columns: [
{
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-11 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 7:58 Daniel Herzig [this message]
2024-11-11 20:30 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111075811.5008-1-d.herzig@proxmox.com \
--to=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox