From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 2/2] ui: cloudinit: disallow unprivileged users to regenerate images
Date: Thu, 7 Nov 2024 15:40:55 +0100 [thread overview]
Message-ID: <20241107144055.202870-2-d.kral@proxmox.com> (raw)
In-Reply-To: <20241107144055.202870-1-d.kral@proxmox.com>
Disables the "Regenerate image" button in the VM CloudInit tab for
users, which lack the necessary permission "VM.Config.CloudInit" for the
CloudInit update API endpoint.
This is a cosmetic change as the CloudInit update API endpoint would
fail because of insufficient permissions anyway.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
Changes since v1:
- remove the now unnecessary permission "VM.Config.CDROM"
www/manager6/qemu/CloudInit.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js
index be902d43..ccad4916 100644
--- a/www/manager6/qemu/CloudInit.js
+++ b/www/manager6/qemu/CloudInit.js
@@ -120,7 +120,10 @@ Ext.define('PVE.qemu.CloudInit', {
}
});
- me.down('#savebtn').setDisabled(!found);
+ let caps = Ext.state.Manager.get('GuiCap');
+ let canRegenerateImage = !!caps.vms['VM.Config.Cloudinit'];
+ me.down('#savebtn').setDisabled(!found || !canRegenerateImage);
+
me.setDisabled(!found);
if (!found) {
me.getView().mask(gettext('No CloudInit Drive found'), ['pve-static-mask']);
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-07 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 14:40 [pve-devel] [PATCH manager v2 1/2] ui: cloudinit: use cloudinit update api when regenerating images Daniel Kral
2024-11-07 14:40 ` Daniel Kral [this message]
2024-11-10 18:59 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107144055.202870-2-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox