From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough
Date: Tue, 5 Nov 2024 11:16:57 +0100 [thread overview]
Message-ID: <20241105111657.18f7053b@rosa.proxmox.com> (raw)
In-Reply-To: <20241105092421.774448-3-d.csapak@proxmox.com>
On Tue, 5 Nov 2024 10:24:21 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:
> Since pve-common commit:
>
> eff5957 (sysfstools: file_write: properly catch errors)
>
> this check here fails now when the reset does not work. It turns out
> that resetting the device is not always necessary, and we previously
> ignored most errors when trying to do so.
>
> To restore that functionality, downgrade this `die` to a warning.
>
> If the device really needs a reset to work, it will either fail later
> during startup, or not work correctly in the guest, but that behavior
> existed before and is AFAIK not really detectable from our side.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/QemuServer/PCI.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
> index 75eac134..dceb8938 100644
> --- a/PVE/QemuServer/PCI.pm
> +++ b/PVE/QemuServer/PCI.pm
> @@ -728,7 +728,7 @@ sub prepare_pci_device {
> } else {
> die "can't unbind/bind PCI group to VFIO '$pciid'\n"
> if !PVE::SysFSTools::pci_dev_group_bind_to_vfio($pciid);
> - die "can't reset PCI device '$pciid'\n"
> + warn "can't reset PCI device '$pciid'\n"
maybe the issue would get more visiblity if we used
PVE::RESTEnvironment::log_warn here?
not really sure if it makes sense to mark the start tasks specifically for
something that worked before without any logline indicating that something
was off - but as I somehow expected to see the task with a warning - I
thought I'd drop this here
> if $info->{has_fl_reset} && !PVE::SysFSTools::pci_dev_reset($info);
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-05 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 9:24 [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour Dominik Csapak
2024-11-05 9:24 ` [pve-devel] [PATCH common 1/1] sysfstools: file_write: log the actual error if there was one Dominik Csapak
2024-11-05 9:24 ` [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough Dominik Csapak
2024-11-05 10:16 ` Stoiko Ivanov [this message]
2024-11-05 10:40 ` Dominik Csapak
2024-11-05 10:12 ` [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour Stoiko Ivanov
2024-11-06 10:51 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105111657.18f7053b@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox