From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common 1/1] sysfstools: file_write: log the actual error if there was one
Date: Tue, 5 Nov 2024 10:24:20 +0100 [thread overview]
Message-ID: <20241105092421.774448-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20241105092421.774448-1-d.csapak@proxmox.com>
the actual error and path is useful to know when tryin to debug or
figure out what did not work, so warn here if there was an error.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/SysFSTools.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm
index 0bde6d7..d0d1bb9 100644
--- a/src/PVE/SysFSTools.pm
+++ b/src/PVE/SysFSTools.pm
@@ -217,7 +217,12 @@ sub file_write {
my $fh = IO::File->new($filename, "w");
return undef if !$fh;
- my $res = defined(syswrite($fh, $buf)) ? 1 : 0;
+ my $res = 0;
+ if (defined(syswrite($fh, $buf))) {
+ $res = 1;
+ } elsif (my $err = $!) {
+ warn "error writing '$buf' to '$filename': $err\n";
+ }
$fh->close();
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-05 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 9:24 [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour Dominik Csapak
2024-11-05 9:24 ` Dominik Csapak [this message]
2024-11-05 9:24 ` [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough Dominik Csapak
2024-11-05 10:16 ` Stoiko Ivanov
2024-11-05 10:40 ` Dominik Csapak
2024-11-05 10:12 ` [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour Stoiko Ivanov
2024-11-06 10:51 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105092421.774448-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox