public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 pve-common 4/5] section config: make subroutine `delete_from_config` private
Date: Thu, 31 Oct 2024 18:07:19 +0100	[thread overview]
Message-ID: <20241031170720.338794-5-m.carrara@proxmox.com> (raw)
In-Reply-To: <20241031170720.338794-1-m.carrara@proxmox.com>

because it's just an internal helper method and isn't used anywhere
outside of the package.

Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
Changes v2 --> v3:
  * none

Changes v1 --> v2:
  * new

 src/PVE/SectionConfig.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm
index 05cd538..aa17391 100644
--- a/src/PVE/SectionConfig.pm
+++ b/src/PVE/SectionConfig.pm
@@ -1617,7 +1617,7 @@ C<$config>.
 
 =cut
 
-sub delete_from_config {
+my sub delete_from_config {
     my ($config, $option_schema, $new_options, $to_delete) = @_;
 
     for my $k ($to_delete->@*) {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-10-31 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 17:07 [pve-devel] [PATCH v3 pve-common 0/5] Section Config: Documentation & Code Cleanup Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 1/5] section config: document package and its methods with POD Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 2/5] section config: update code style Max Carrara
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 3/5] section config: clean up parser logic and semantics Max Carrara
2024-10-31 17:07 ` Max Carrara [this message]
2024-10-31 17:07 ` [pve-devel] [PATCH v3 pve-common 5/5] section config: fix spelling of variable Max Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241031170720.338794-5-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal