From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH proxmox-firewall v2 1/2] firewall: cargo: use new cargo feature resolver
Date: Thu, 31 Oct 2024 14:31:43 +0100 [thread overview]
Message-ID: <20241031133143.z6ehuvgbu4ho5aar@luna.proxmox.com> (raw)
In-Reply-To: <1730379717.6p0rtigrfm.astroid@yuna.none>
On 31.10.2024 14:04, Fabian Grünbichler wrote:
>On October 31, 2024 11:10 am, Gabriel Goller wrote:
>> Virtual cargo workspaces (workspaces without a [package] section)
>> default to the cargo feature resolver "1" – even though this outputs a
>> warning on every cargo invocation. To remove the warning, explicitly set
>> the resolver to version "2".
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>>
>> v2:
>> - nothing changed
>>
>> Cargo.toml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Cargo.toml b/Cargo.toml
>> index 8fba806ad2a5..3894d9f703a1 100644
>> --- a/Cargo.toml
>> +++ b/Cargo.toml
>> @@ -3,6 +3,7 @@ members = [
>> "proxmox-nftables",
>> "proxmox-firewall",
>> ]
>> +resolver = "2"
>>
>> [workspace.dependencies]
>> proxmox-ve-config = { version = "0.1.0" }
>
>where does this part come from? not on current master at least ;)
>adapted it to the current Cargo.toml and applied, since the resulting
>.deb files are identical anyhow..
Oops, forgot to mention it – this (the second patch) obviously depends
on the ipset series by Stefan.
(https://lore.proxmox.com/pve-devel/20241010155637.255451-1-s.hanreich@proxmox.com/.)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-31 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 10:10 [pve-devel] " Gabriel Goller
2024-10-31 10:10 ` [pve-devel] [PATCH proxmox-firewall v2 2/2] firewall: delete unused sets Gabriel Goller
2024-10-31 13:04 ` [pve-devel] applied: [PATCH proxmox-firewall v2 1/2] firewall: cargo: use new cargo feature resolver Fabian Grünbichler
2024-10-31 13:31 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031133143.z6ehuvgbu4ho5aar@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox