public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] api: node: index: use standard fingerprint-sha256 option
Date: Wed, 30 Oct 2024 14:44:02 +0100	[thread overview]
Message-ID: <20241030134402.310205-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20241030134402.310205-1-m.sandoval@proxmox.com>

This adds a regex check for valid fingerprints.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Diferences from v1:
 - Use get_standard_option

 PVE/API2/Nodes.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 1db148af..8dddf58b 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -2566,11 +2566,10 @@ __PACKAGE__->register_method ({
 		    optional => 1,
 		    renderer => 'duration',
 		},
-		ssl_fingerprint => {
+		ssl_fingerprint => get_standard_option('fingerprint-sha256', {
 		    description => "The SSL SHA-256 fingerprint for the node certificate.",
-		    type => 'string',
 		    optional => 1,
-		},
+		}),
 	    },
 	},
 	links => [ { rel => 'child', href => "{node}" } ],
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-10-30 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 13:44 [pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate Maximiliano Sandoval
2024-10-30 13:44 ` Maximiliano Sandoval [this message]
2024-10-30 13:58   ` [pve-devel] [PATCH manager 2/2] api: node: index: use standard fingerprint-sha256 option Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030134402.310205-2-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal