From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/1] status: add some missing description for status return properties
Date: Mon, 21 Oct 2024 11:15:39 +0200 [thread overview]
Message-ID: <20241021091542.1017657-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20241021091542.1017657-1-d.csapak@proxmox.com>
i omitted the 'disk' property, since it's non functional currently,
since we don't query the disk usage here (complicated to calculate,
depending on the storage, or requires guest agent support, which is also
non-trivial)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
PVE/QemuServer.pm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b26da505..e6df6091 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2764,11 +2764,39 @@ our $vmstatus_return_properties = {
optional => 1,
renderer => 'bytes',
},
+ diskread => {
+ description => "The amount of bytes the guest read from it's disks since the process"
+ ." start in bytes.",
+ type => 'integer',
+ optional => 1,
+ renderer => 'bytes',
+ },
+ diskwrite => {
+ description => "The amount of bytes the guest wrote to it's disks since the process"
+ ." start in bytes.",
+ type => 'integer',
+ optional => 1,
+ renderer => 'bytes',
+ },
name => {
description => "VM name.",
type => 'string',
optional => 1,
},
+ netin => {
+ description => "The amount of traffic that was sent to the guest since the process start,"
+ ." in bytes.",
+ type => 'integer',
+ optional => 1,
+ renderer => 'bytes',
+ },
+ netin => {
+ description => "The amount of traffic that was sent from the guest since the process start,"
+ ." in bytes.",
+ type => 'integer',
+ optional => 1,
+ renderer => 'bytes',
+ },
qmpstatus => {
description => "VM run state from the 'query-status' QMP monitor command.",
type => 'string',
@@ -2810,6 +2838,12 @@ our $vmstatus_return_properties = {
type => 'string',
optional => 1,
},
+ template => {
+ description => "Determines if the guest is a template.",
+ type => 'boolean',
+ optional => 1,
+ default => 0,
+ },
};
my $last_proc_pid_stat;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-21 9:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 9:15 [pve-devel] [PATCH qemu-server/container/manager] add some missing return schema descriptions Dominik Csapak
2024-10-21 9:15 ` Dominik Csapak [this message]
2024-10-24 13:53 ` [pve-devel] applied: [PATCH qemu-server 1/1] status: add some missing description for status return properties Thomas Lamprecht
2024-10-21 9:15 ` [pve-devel] [PATCH container 1/1] status: add some missing descriptions " Dominik Csapak
2024-10-24 12:20 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-24 15:05 ` Dominik Csapak
2024-10-24 15:12 ` Thomas Lamprecht
2024-10-21 9:15 ` [pve-devel] [PATCH manager 1/2] api: subscription: add return schema for 'GET' api Dominik Csapak
2024-10-24 15:02 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-21 9:15 ` [pve-devel] [PATCH manager 2/2] api: cluster/resources: add missing return properties Dominik Csapak
2024-10-24 15:02 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021091542.1017657-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox