[pve-devel] [PATCH qemu-server 4/4] templates: add documentation to template_create

[Daniel Kral <d.kral@proxmox.com>]

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 PVE/QemuServer.pm | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b26da505..114bafc5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -7794,7 +7794,17 @@ sub qga_check_running {
     return 1;
 }
 
-sub template_create {
+=head3 template_create($vmid, $conf [, $disk])
+
+Converts all used disk volumes for the VM with the identifier C<$vmid> and
+configuration C<$conf> to base images (e.g. for VM templates).
+
+If the optional C<$disk> parameter is set, it will only convert the disk
+volume at the specified drive name (e.g. "scsi0").
+
+=cut
+
+sub template_create : prototype($$;$) {
     my ($vmid, $conf, $disk) = @_;
 
     my $storecfg = PVE::Storage::config();
@@ -7811,6 +7821,8 @@ sub template_create {
 	my $voliddst = PVE::Storage::vdisk_create_base($storecfg, $volid);
 	$drive->{file} = $voliddst;
 	$conf->{$ds} = print_drive($drive);
+
+	# write vm config on every change in case this fails on subsequent iterations
 	PVE::QemuConfig->write_config($vmid, $conf);
     });
 }
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel