[pve-devel] [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema

[pve-devel] [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema

[Fabian Grünbichler]

using the definition already used in the task index API schema in the same
module.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is
the return schema it doesn't really matter I guess, but might be worth it to
settle on one or the other for all 4 instances of pstart/starttime here?

 PVE/API2/Tasks.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index b763b74d8..4ea9832b8 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -482,6 +482,9 @@ __PACKAGE__->register_method({
 	    starttime => {
 		type => 'number',
 	    },
+	    pstart => {
+		type => 'integer',
+	    },
 	    node => {
 		type => 'string',
 	    },
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema

[Thomas Lamprecht]

On 04/10/2024 10:34, Fabian Grünbichler wrote:
> using the definition already used in the task index API schema in the same
> module.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is
> the return schema it doesn't really matter I guess, but might be worth it to
> settle on one or the other for all 4 instances of pstart/starttime here?

yeah, that would be nice. Using integer, like you did, might be the best
option for non-fractional UNIX seconds I think. 

> 
>  PVE/API2/Tasks.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel