From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #5734: provide missing methods for Proxmox.Utils for mobile ui
Date: Mon, 23 Sep 2024 12:33:31 +0200 [thread overview]
Message-ID: <20240923103331.1508338-1-d.csapak@proxmox.com> (raw)
since the mobile ui shares the Utils code with the desktop web ui, (but
not the proxmox-widget-toolkit) all methods used in constructors, etc.
there must be available in the mobile ui too.
We don't have any notification configuration options in the mobile ui,
and AFAIK we don't plan to add those there, so we can just implement
stub functions. This way the Utils constructor can proceed without
errors, fixing loading the mobile ui.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/mobile/WidgetToolkitUtils.js | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/www/mobile/WidgetToolkitUtils.js b/www/mobile/WidgetToolkitUtils.js
index b292fcd5..ea710faf 100644
--- a/www/mobile/WidgetToolkitUtils.js
+++ b/www/mobile/WidgetToolkitUtils.js
@@ -586,6 +586,15 @@ utilities: {
}
},
+ overrideNotificationFieldName: function(extra) {
+ // do nothing, we don't have notification configuration in mobile ui
+ },
+
+ overrideNotificationFieldValue: function(extra) {
+ // do nothing, we don't have notification configuration in mobile ui
+ },
+
+
format_task_description: function(type, id) {
let farray = Proxmox.Utils.task_desc_table[type];
let text;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-09-23 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 10:33 Dominik Csapak [this message]
2024-09-25 12:49 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923103331.1508338-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox