From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server 03/10] test: cfg2cmd: don't use QEMU binary version less than 4.0 for tests
Date: Fri, 6 Sep 2024 16:37:19 +0200 [thread overview]
Message-ID: <20240906143719.238434-1-d.kral@proxmox.com> (raw)
In-Reply-To: <20240723152548.129832-4-f.ebner@proxmox.com>
Another small misspelling in the following tests:
s/wih/with
On Tue, 23 Jul 2024 17:25:40 +0200, Fiona Ebner wrote:
> diff --git a/test/cfg2cmd/memory-hugepages-1g.conf b/test/cfg2cmd/memory-hugepages-1g.conf
> index 8db2cca6..567a24d9 100644
> --- a/test/cfg2cmd/memory-hugepages-1g.conf
> +++ b/test/cfg2cmd/memory-hugepages-1g.conf
> @@ -1,5 +1,4 @@
> # TEST: memory wih 1gb hugepages
and
On Tue, 23 Jul 2024 17:25:40 +0200, Fiona Ebner wrote:
> diff --git a/test/cfg2cmd/memory-hugepages-2m.conf b/test/cfg2cmd/memory-hugepages-2m.conf
> index f0d65fbd..50d53f0d 100644
> --- a/test/cfg2cmd/memory-hugepages-2m.conf
> +++ b/test/cfg2cmd/memory-hugepages-2m.conf
> @@ -1,5 +1,4 @@
> # TEST: memory wih 2mb hugepages
Otherwise:
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-06 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 15:25 [pve-devel] [PATCH-SERIES qemu-server] cfg2cmd: bump minimum binary version to 5.0 and test for QEMU machine version instead of binary version Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 01/10] code cleanup: drop unused parameter from get_vm_machine() Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 02/10] test: bump QEMU version in tests for too new machine type and pve version Fiona Ebner
2024-09-06 14:36 ` Daniel Kral
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 03/10] test: cfg2cmd: don't use QEMU binary version less than 4.0 for tests Fiona Ebner
2024-09-06 14:37 ` Daniel Kral [this message]
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 04/10] cfg2cmd: require at least QEMU binary version 4.0 Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 05/10] test: cfg2cmd: don't use QEMU binary version less than 5.0 for tests Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 06/10] cfg2cmd: require at least QEMU binary version 5.0 Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 07/10] cfg2cmd: drop superfluous check for QEMU binary version 4.1 Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 08/10] test: cfg2cmd: don't use QEMU binary version less than 6.0 for tests Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 09/10] test: cfg2cmd: don't use QEMU binary version less than 7.0 " Fiona Ebner
2024-07-23 15:25 ` [pve-devel] [PATCH qemu-server 10/10] test: cfg2cmd: don't use QEMU binary version less than 8.0 " Fiona Ebner
2024-09-06 14:39 ` Daniel Kral
2024-09-09 7:42 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906143719.238434-1-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox