[pve-devel] [PATCH docs] pve-network: correct language errors

[pve-devel] [PATCH docs] pve-network: correct language errors

[Alexander Zeidler]

Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
 pve-network.adoc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pve-network.adoc b/pve-network.adoc
index acdcf39..434430d 100644
--- a/pve-network.adoc
+++ b/pve-network.adoc
@@ -447,7 +447,7 @@ slaves in the single logical bonded interface such that different
 network-peers use different MAC addresses for their network packet
 traffic.
 
-If your switch support the LACP (IEEE 802.3ad) protocol then we recommend using
+If your switch supports the LACP (IEEE 802.3ad) protocol then we recommend using
 the corresponding bonding mode (802.3ad). Otherwise you should generally use the
 active-backup mode.
 
@@ -490,7 +490,7 @@ iface vmbr0 inet static
 
 
 [thumbnail="default-network-setup-bond.svg"]
-Another possibility it to use the bond directly as bridge port.
+Another possibility is to use the bond directly as bridge port.
 This can be used to make the guest network fault-tolerant.
 
 .Example: Use a bond as bridge port
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH docs] pve-network: correct language errors

[Lukas Wagner]

On  2024-08-13 12:23, Alexander Zeidler wrote:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  pve-network.adoc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pve-network.adoc b/pve-network.adoc
> index acdcf39..434430d 100644
> --- a/pve-network.adoc
> +++ b/pve-network.adoc
> @@ -447,7 +447,7 @@ slaves in the single logical bonded interface such that different
>  network-peers use different MAC addresses for their network packet
>  traffic.
>  
> -If your switch support the LACP (IEEE 802.3ad) protocol then we recommend using
> +If your switch supports the LACP (IEEE 802.3ad) protocol then we recommend using
                                                                   ^
There should be comma here: If ..., then ...

>  the corresponding bonding mode (802.3ad). Otherwise you should generally use the
>  active-backup mode.
>  
> @@ -490,7 +490,7 @@ iface vmbr0 inet static
>  
>  
>  [thumbnail="default-network-setup-bond.svg"]
> -Another possibility it to use the bond directly as bridge port.
> +Another possibility is to use the bond directly as bridge port.
>  This can be used to make the guest network fault-tolerant.
>  
>  .Example: Use a bond as bridge port

Apart from this, this looks good to me:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

-- 
- Lukas


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs] pve-network: correct language errors

[Fiona Ebner]

Am 13.08.24 um 12:23 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  pve-network.adoc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pve-network.adoc b/pve-network.adoc
> index acdcf39..434430d 100644
> --- a/pve-network.adoc
> +++ b/pve-network.adoc
> @@ -447,7 +447,7 @@ slaves in the single logical bonded interface such that different
>  network-peers use different MAC addresses for their network packet
>  traffic.
>  
> -If your switch support the LACP (IEEE 802.3ad) protocol then we recommend using
> +If your switch supports the LACP (IEEE 802.3ad) protocol then we recommend using
>  the corresponding bonding mode (802.3ad). Otherwise you should generally use the
>  active-backup mode.
>  
> @@ -490,7 +490,7 @@ iface vmbr0 inet static
>  
>  
>  [thumbnail="default-network-setup-bond.svg"]
> -Another possibility it to use the bond directly as bridge port.
> +Another possibility is to use the bond directly as bridge port.
>  This can be used to make the guest network fault-tolerant.
>  
>  .Example: Use a bond as bridge port

applied, thanks! While adding the missing comma Lukas noted and his R-b.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH docs] pve-network: correct language errors

[Fiona Ebner]

Am 13.08.24 um 15:57 schrieb Fiona Ebner:
> Am 13.08.24 um 12:23 schrieb Alexander Zeidler:
>> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
>> ---
>>  pve-network.adoc | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/pve-network.adoc b/pve-network.adoc
>> index acdcf39..434430d 100644
>> --- a/pve-network.adoc
>> +++ b/pve-network.adoc
>> @@ -447,7 +447,7 @@ slaves in the single logical bonded interface such that different
>>  network-peers use different MAC addresses for their network packet
>>  traffic.
>>  
>> -If your switch support the LACP (IEEE 802.3ad) protocol then we recommend using
>> +If your switch supports the LACP (IEEE 802.3ad) protocol then we recommend using
>>  the corresponding bonding mode (802.3ad). Otherwise you should generally use the
>>  active-backup mode.
>>  
>> @@ -490,7 +490,7 @@ iface vmbr0 inet static
>>  
>>  
>>  [thumbnail="default-network-setup-bond.svg"]
>> -Another possibility it to use the bond directly as bridge port.
>> +Another possibility is to use the bond directly as bridge port.
>>  This can be used to make the guest network fault-tolerant.
>>  
>>  .Example: Use a bond as bridge port
> 
> applied, thanks! While adding the missing comma Lukas noted and his R-b.

I also added a follow-up using "as the bridge port" instead of "as
bridge port" while at it.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel