public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 2/2] low level: config: filter out all installer-related kernel arguments
Date: Fri,  9 Aug 2024 13:51:43 +0200	[thread overview]
Message-ID: <20240809115145.1005005-3-c.heiss@proxmox.com> (raw)
In-Reply-To: <20240809115145.1005005-1-c.heiss@proxmox.com>

For one, include the auto-installer arguments, which weren't filtered
out before. Secondely, include the aliases as introduced in [0].

[0] de7f779 ("unconfigured: accept more telling boot cmdline option names")

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 Proxmox/Install/Config.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm
index 6b064b1..976f7a1 100644
--- a/Proxmox/Install/Config.pm
+++ b/Proxmox/Install/Config.pm
@@ -44,7 +44,8 @@ my sub parse_kernel_cmdline {
     }
 
     $cmdline =~ s/\b(?:BOOT_IMAGE|root|ramdisk_size|splash|vga)=\S+\s?\b//gi;
-    $cmdline =~ s/\bro|rw|quiet|proxdebug|proxtui|nomodeset\b//gi;
+    $cmdline =~ s/\bro|rw|quiet|nomodeset\b//gi;
+    $cmdline =~ s/\bprox(debug|tui|auto)|proxmox-\S+\b//gi;
 
     $cfg->{target_cmdline}= $cmdline;
 
-- 
2.45.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-08-09 11:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 11:51 [pve-devel] [PATCH installer 0/2] properly " Christoph Heiss
2024-08-09 11:51 ` [pve-devel] [PATCH installer 1/2] low level: config: filter out kernel cmdline on word boundaries Christoph Heiss
2024-08-14 10:51   ` Alexander Zeidler
2024-08-21  9:35     ` Christoph Heiss
2024-08-09 11:51 ` Christoph Heiss [this message]
2024-08-21 13:24 ` [pve-devel] [PATCH installer 0/2] properly filter out all installer-related kernel arguments Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240809115145.1005005-3-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal