From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit v3 7/6 follow-up] Network: add explanation for bridge vids field
Date: Tue, 23 Jul 2024 15:33:13 +0200 [thread overview]
Message-ID: <20240723133313.383509-1-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20240703080147.81154-1-a.lauterer@proxmox.com>
Make clear that it affects only out-/inbound traffic and can be used if
the underlying physical NICs support only a limited number of VLANs when
offloading is possible.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
After some off-list discussion with @Stefan Hanreich after his review,
we came to the conclusion that some explanation is needed to avoid
confusion.
I am not too happy with how long the explanation is, if someone has a
better idea to transport that information, I am absolutely not opposed
to it.
src/node/NetworkEdit.js | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index 8c1b135..1149dee 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -109,6 +109,12 @@ Ext.define('Proxmox.node.NetworkEdit', {
return true;
},
});
+ let vidsExplanation = Ext.create('Ext.form.field.Display', {
+ disabled: true,
+ userCls: 'pmx-hint',
+ value: 'Use if you want the bridge ports to only forward a limited number of ' +
+ 'VLANs or the physical NICs support a limited number of offloaded VLANs.',
+ });
column2.push({
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('VLAN aware'),
@@ -118,6 +124,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
change: function(f, newVal) {
if (me.bridge_set_vids) {
vids.setDisabled(!newVal);
+ vidsExplanation.setDisabled(!newVal);
}
},
},
@@ -133,6 +140,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
});
if (me.bridge_set_vids) {
advancedColumn2.push(vids);
+ advancedColumn2.push(vidsExplanation);
}
} else if (me.iftype === 'OVSBridge') {
column2.push({
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-23 13:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 8:01 [pve-devel] [PATCH common, widget-toolkit, manager v3 0/3] fix #3893: make bridge vids configurable Aaron Lauterer
2024-07-03 8:01 ` [pve-devel] [PATCH common v3 1/3] tools: add check_list_empty function Aaron Lauterer
2024-07-03 8:01 ` [pve-devel] [PATCH common v3 2/3] fix #3893: network: add vlan id and range parameter definitions Aaron Lauterer
2024-07-26 12:22 ` Shannon Sterz
2024-07-03 8:01 ` [pve-devel] [PATCH common v3 3/3] inotify: interfaces: make sure bridge_vids use space as separator Aaron Lauterer
2024-07-03 8:01 ` [pve-devel] [PATCH widget-toolkit v3] fix #3892: Network: add bridge vids field for bridge_vids Aaron Lauterer
2024-07-26 12:22 ` Shannon Sterz
2024-07-29 10:25 ` Aaron Lauterer
2024-07-29 10:42 ` Shannon Sterz
2024-07-03 8:01 ` [pve-devel] [PATCH manager v3 5/6] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2024-07-26 12:23 ` Shannon Sterz
2024-07-03 8:01 ` [pve-devel] [PATCH manager v3 6/6] fix #3893: ui: network: enable bridge_vids field Aaron Lauterer
2024-07-23 11:24 ` [pve-devel] [PATCH common, widget-toolkit, manager v3 0/3] fix #3893: make bridge vids configurable Stefan Hanreich
2024-07-23 13:33 ` Aaron Lauterer [this message]
2024-07-26 12:23 ` [pve-devel] [PATCH widget-toolkit v3 7/6 follow-up] Network: add explanation for bridge vids field Shannon Sterz
2024-07-26 12:22 ` [pve-devel] [PATCH common, widget-toolkit, manager v3 0/3] fix #3893: make bridge vids configurable Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723133313.383509-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox