[pve-devel] [PATCH manager 1/5] fix typos in comments

[pve-devel] [PATCH manager 1/5] fix typos in comments

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/Nodes.pm                       | 2 +-
 PVE/APLInfo.pm                          | 2 +-
 PVE/CLI/pveceph.pm                      | 2 +-
 PVE/Service/pvestatd.pm                 | 2 +-
 PVE/Status/Plugin.pm                    | 2 +-
 www/manager6/Parser.js                  | 2 +-
 www/manager6/ceph/Services.js           | 2 +-
 www/manager6/dc/ACMEPluginEdit.js       | 2 +-
 www/manager6/form/BandwidthSelector.js  | 2 +-
 www/manager6/lxc/ResourceEdit.js        | 2 +-
 www/manager6/qemu/OSDefaults.js         | 2 +-
 www/manager6/qemu/PCIEdit.js            | 2 +-
 www/manager6/qemu/ProcessorEdit.js      | 2 +-
 www/manager6/window/Migrate.js          | 2 +-
 www/manager6/window/Restore.js          | 2 +-
 www/manager6/window/TreeSettingsEdit.js | 2 +-
 www/u2f-api.js                          | 2 +-
 17 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 6d1112e5..9920e977 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -399,7 +399,7 @@ __PACKAGE__->register_method({
 	type => "object",
 	additionalProperties => 1,
 	properties => {
-	    # TODO: document remaing ones
+	    # TODO: document remaining ones
 	    'boot-info' => {
 		description => "Meta-information about the boot mode.",
 		type => 'object',
diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm
index 821d645c..9ea20678 100644
--- a/PVE/APLInfo.pm
+++ b/PVE/APLInfo.pm
@@ -86,7 +86,7 @@ sub read_aplinfo_from_fh {
 		$template = $res->{location};
 		$template =~ s|.*/([^/]+$PVE::Storage::VZTMPL_EXT_RE_1)$|$1|;
 		if ($res->{location} !~ m|^([a-zA-Z]+)\://|) {
-		    # relative localtion (no http:// prefix)
+		    # relative location (no http:// prefix)
 		    $res->{location} = "$source/$res->{location}";
 		}
 	    } else {
diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index 5f45610b..b7b92187 100755
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -216,7 +216,7 @@ __PACKAGE__->register_method ({
 
 	print "start installation\n";
 
-	# this flag helps to determine when apt is actually done installing (vs. partial extracing)
+	# this flag helps to determine when apt is actually done installing (vs. partial extracting)
 	my $install_flag_fn = PVE::Ceph::Tools::ceph_install_flag_file();
 	open(my $install_flag, '>', $install_flag_fn) or die "could not create install flag - $!\n";
 	close $install_flag;
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 8661f774..458f22f7 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -103,7 +103,7 @@ sub update_supported_cpuflags {
 
 	$supported_cpuflags = {};
     } else {
-	# only set cached version if there's actually something to braodcast
+	# only set cached version if there's actually something to broadcast
 	$cached_kvm_version = $kvm_version;
     }
 
diff --git a/PVE/Status/Plugin.pm b/PVE/Status/Plugin.pm
index 97976b97..1b3de52f 100644
--- a/PVE/Status/Plugin.pm
+++ b/PVE/Status/Plugin.pm
@@ -89,7 +89,7 @@ sub _send_batch_size {
     return $mtu - 50; # a bit more than 48byte to allow for safe room
 }
 
-# call with the smalles $data chunks possible
+# call with the smallest $data chunks possible
 sub add_metric_data {
     my ($class, $txn, $data) = @_;
     return if !defined($data);
diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js
index 77b2b2fc..07eb9b17 100644
--- a/www/manager6/Parser.js
+++ b/www/manager6/Parser.js
@@ -65,7 +65,7 @@ Ext.define('PVE.Parser', {
 		    if (Ext.isDefined(res[defaultKey])) {
 			throw 'defaultKey may be only defined once in propertyString';
 		    }
-		    res[defaultKey] = k; // k ist the value in this case
+		    res[defaultKey] = k; // k is the value in this case
 		} else {
 		    throw `Failed to parse key-value pair: ${property}`;
 		}
diff --git a/www/manager6/ceph/Services.js b/www/manager6/ceph/Services.js
index b9fc52c8..dfafee43 100644
--- a/www/manager6/ceph/Services.js
+++ b/www/manager6/ceph/Services.js
@@ -265,7 +265,7 @@ Ext.define('PVE.ceph.ServiceList', {
 		});
 		me.ids.push(list[i].id);
 	    } else {
-		delete pendingRemoval[list[i].id]; // drop exisiting from for-removal
+		delete pendingRemoval[list[i].id]; // drop existing from for-removal
 	    }
 	    service.updateService(list[i].title, list[i].text, list[i].health);
 	}
diff --git a/www/manager6/dc/ACMEPluginEdit.js b/www/manager6/dc/ACMEPluginEdit.js
index 570b4dd2..62ecbcce 100644
--- a/www/manager6/dc/ACMEPluginEdit.js
+++ b/www/manager6/dc/ACMEPluginEdit.js
@@ -124,7 +124,7 @@ Ext.define('PVE.dc.ACMEPluginEditor', {
 		datafield.setValue(extradata.join('\n'));
 		if (!me.createdInitially) {
 		    datafield.resetOriginalValue();
-		    me.createdInitially = true; // save that we initally set that
+		    me.createdInitially = true; // save that we initially set that
 		}
 	    },
 	    onGetValues: function(values) {
diff --git a/www/manager6/form/BandwidthSelector.js b/www/manager6/form/BandwidthSelector.js
index 6f20af3a..50c5d671 100644
--- a/www/manager6/form/BandwidthSelector.js
+++ b/www/manager6/form/BandwidthSelector.js
@@ -37,7 +37,7 @@ Ext.define('PVE.form.SizeField', {
     unit: 'MiB',
     unitPostfix: '',
 
-    // use this if the backend saves values in another unit tha bytes, e.g.,
+    // use this if the backend saves values in a unit other than bytes, e.g.,
     // for KiB set it to 'KiB'
     backendUnit: undefined,
 
diff --git a/www/manager6/lxc/ResourceEdit.js b/www/manager6/lxc/ResourceEdit.js
index 9f4f7e08..a0d868ee 100644
--- a/www/manager6/lxc/ResourceEdit.js
+++ b/www/manager6/lxc/ResourceEdit.js
@@ -43,7 +43,7 @@ Ext.define('PVE.lxc.CPUEdit', {
     },
 });
 
-// The view model of the parent shoul contain a 'cgroupMode' variable (or params for v2 are used).
+// The view model of the parent should contain a 'cgroupMode' variable (or params for v2 are used).
 Ext.define('PVE.lxc.CPUInputPanel', {
     extend: 'Proxmox.panel.InputPanel',
     alias: 'widget.pveLxcCPUInputPanel',
diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index 58bc76ff..d3ee4946 100644
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -61,7 +61,7 @@ Ext.define('PVE.qemu.OSDefaults', {
 	    networkCard: 'virtio',
 	});
 
-	// recommandation from http://wiki.qemu.org/Windows2000
+	// recommendation from http://wiki.qemu.org/Windows2000
 	addOS({
 	    pveOS: 'w2k',
 	    parent: 'generic',
diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 8cef1b10..970e81c2 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -180,7 +180,7 @@ Ext.define('PVE.qemu.PCIInputPanel', {
 		columnWidth: 1,
 		padding: '0 0 10 0',
 		itemId: 'iommuwarning',
-		value: 'The selected Device is not in a seperate IOMMU group, make sure this is intended.',
+		value: 'The selected Device is not in a separate IOMMU group, make sure this is intended.',
 		userCls: 'pmx-hint',
 	    },
 	];
diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
index b3538727..7aa98eb6 100644
--- a/www/manager6/qemu/ProcessorEdit.js
+++ b/www/manager6/qemu/ProcessorEdit.js
@@ -1,4 +1,4 @@
-// The view model of the parent shoul contain a 'cgroupMode' variable (or params for v2 are used).
+// The view model of the parent should contain a 'cgroupMode' variable (or params for v2 are used).
 Ext.define('PVE.qemu.ProcessorInputPanel', {
     extend: 'Proxmox.panel.InputPanel',
     alias: 'widget.pveQemuProcessorPanel',
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 5473821b..78d03921 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -102,7 +102,7 @@ Ext.define('PVE.window.Migrate', {
 	},
 
 	onTargetChange: function(nodeSelector) {
-	    // Always display the storages of the currently seleceted migration target
+	    // Always display the storages of the currently selected migration target
 	    this.lookup('pveDiskStorageSelector').setNodename(nodeSelector.value);
 	    this.checkMigratePreconditions();
 	},
diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index 36aecc39..6efe1313 100644
--- a/www/manager6/window/Restore.js
+++ b/www/manager6/window/Restore.js
@@ -132,7 +132,7 @@ Ext.define('PVE.window.Restore', {
 
 			if (key === '#qmdump#map') {
 			    let match = value.match(/^(\S+):(\S+):(\S*):(\S*):$/) ?? [];
-			    // if a /dev/XYZ disk was backed up, ther is no storage hint
+			    // if a /dev/XYZ disk was backed up, there is no storage hint
 			    allStoragesAvailable &&= !!match[3] && !!PVE.data.ResourceStore.getById(
 				`storage/${view.nodename}/${match[3]}`);
 			} else if (key === 'name' || key === 'hostname') {
diff --git a/www/manager6/window/TreeSettingsEdit.js b/www/manager6/window/TreeSettingsEdit.js
index ed8b7ade..b48415bc 100644
--- a/www/manager6/window/TreeSettingsEdit.js
+++ b/www/manager6/window/TreeSettingsEdit.js
@@ -5,7 +5,7 @@ Ext.define('PVE.window.TreeSettingsEdit', {
     title: gettext('Tree Settings'),
     isCreate: false,
 
-    url: '#', // ignored as submit() gets overriden here, but the parent class requires it
+    url: '#', // ignored as submit() gets overridden here, but the parent class requires it
 
     width: 450,
     fieldDefaults: {
diff --git a/www/u2f-api.js b/www/u2f-api.js
index 9244d14e..60c1355c 100644
--- a/www/u2f-api.js
+++ b/www/u2f-api.js
@@ -37,7 +37,7 @@ var js_api_version;
 
 
 /**
- * Message types for messsages to/from the extension
+ * Message types for messages to/from the extension
  * @const
  * @enum {string}
  */
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/5] ui: ceph: rename wizzard variable to wizard

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/window/CephInstall.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/window/CephInstall.js b/www/manager6/window/CephInstall.js
index 432c6719..32605129 100644
--- a/www/manager6/window/CephInstall.js
+++ b/www/manager6/window/CephInstall.js
@@ -66,12 +66,12 @@ Ext.define('PVE.ceph.Install', {
 	    },
 	    handler: function() {
 		let view = this.up('pveCephInstallWindow');
-		let wizzard = Ext.create('PVE.ceph.CephInstallWizard', {
+		let wizard = Ext.create('PVE.ceph.CephInstallWizard', {
 		    nodename: view.nodename,
 		});
-		wizzard.getViewModel().set('isInstalled', this.getViewModel().get('isInstalled'));
-		wizzard.show();
-		view.mon(wizzard, 'beforeClose', function() {
+		wizard.getViewModel().set('isInstalled', this.getViewModel().get('isInstalled'));
+		wizard.show();
+		view.mon(wizard, 'beforeClose', function() {
 		    view.fireEvent("cephInstallWindowClosed");
 		    view.close();
 		});
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 3/5] guest import: fix attaced typo in translatable string

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/window/GuestImport.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 4bedc211..2577ece2 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -929,7 +929,7 @@ Ext.define('PVE.window.GuestImport', {
 	let renderWarning = w => {
 	    const warningsCatalogue = {
 		'cdrom-image-ignored': gettext("CD-ROM images cannot get imported, if required you can reconfigure the '{0}' drive in the 'Advanced' tab."),
-		'nvme-unsupported': gettext("NVMe disks are currently not supported, '{0}' will get attaced as SCSI"),
+		'nvme-unsupported': gettext("NVMe disks are currently not supported, '{0}' will get attached as SCSI"),
 		'ovmf-with-lsi-unsupported': gettext("OVMF is built without LSI drivers, scsi hardware was set to '{1}'"),
 		'serial-port-socket-only': gettext("Serial socket '{0}' will be mapped to a socket"),
 		'guest-is-running': gettext('Virtual guest seems to be running on source host. Import might fail or have inconsistent state!'),
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 4/5] makefile: fix waring typo

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 bin/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/Makefile b/bin/Makefile
index 180a91b5..82d5c633 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -68,7 +68,7 @@ pve7to8.1:
 	printf ".TH PVE7TO8 1\n.SH NAME\npve7to8 \- Proxmox VE upgrade checker script for 7.4+ to current 8.x\n" > $@.tmp
 	printf ".SH DESCRIPTION\nThis tool will help you to detect common pitfalls and misconfguration\
 	 before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp
-	printf "Any failure must be addressed before the upgrade, and any waring must be addressed, \
+	printf "Any failure must be addressed before the upgrade, and any warning must be addressed, \
 	 or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp
 	printf ".SH SYNOPSIS\npve7to8 [--full]\n" >> $@.tmp
 	mv $@.tmp $@
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 5/5] ceph: osd: fix canot typo

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/Ceph/OSD.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index 2893456a..5e39eed7 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -323,7 +323,7 @@ __PACKAGE__->register_method ({
 	# 'ceph-volume lvm batch' and they don't make a lot of sense on fast NVMEs anyway.
 	if ($param->{'osds-per-device'}) {
 	    for my $type ( qw(db_dev wal_dev) ) {
-		raise_param_exc({ $type => "canot use 'osds-per-device' parameter with '${type}'" })
+		raise_param_exc({ $type => "cannot use 'osds-per-device' parameter with '${type}'" })
 		    if $param->{$type};
 	    }
 	}
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH manager 1/5] fix typos in comments

[Thomas Lamprecht]

Am 17/07/2024 um 14:16 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  PVE/API2/Nodes.pm                       | 2 +-
>  PVE/APLInfo.pm                          | 2 +-
>  PVE/CLI/pveceph.pm                      | 2 +-
>  PVE/Service/pvestatd.pm                 | 2 +-
>  PVE/Status/Plugin.pm                    | 2 +-
>  www/manager6/Parser.js                  | 2 +-
>  www/manager6/ceph/Services.js           | 2 +-
>  www/manager6/dc/ACMEPluginEdit.js       | 2 +-
>  www/manager6/form/BandwidthSelector.js  | 2 +-
>  www/manager6/lxc/ResourceEdit.js        | 2 +-
>  www/manager6/qemu/OSDefaults.js         | 2 +-
>  www/manager6/qemu/PCIEdit.js            | 2 +-
>  www/manager6/qemu/ProcessorEdit.js      | 2 +-
>  www/manager6/window/Migrate.js          | 2 +-
>  www/manager6/window/Restore.js          | 2 +-
>  www/manager6/window/TreeSettingsEdit.js | 2 +-
>  www/u2f-api.js                          | 2 +-
>  17 files changed, 17 insertions(+), 17 deletions(-)
> 
>

applied series, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel