From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool
Date: Thu, 11 Jul 2024 13:57:52 +0200 [thread overview]
Message-ID: <20240711115804.706227-1-c.heiss@proxmox.com> (raw)
Pretty straight forward overall, implements a check for an existing
`rpool` on the system and ask the user whether they would like to rename
it, much in the same way as it works for VGs already.
Without this, the installer would silently create a second (and thus
conflicting) `rpool` and cause a boot failure after the installation,
since it does not know which pool to import exactly.
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html
v2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064619.html
Notable changes v2 -> v3:
* make low-level option lvm_auto_rename more generic
* skip rename prompt in auto-install mode
Notable changes v1 -> v2:
* incorporated Aarons suggestions from v1
* rewrote tests to use a pre-defined input instead
* moved pool renaming to own subroutine
* documented all new subroutines
* split out tests into own patch
Christoph Heiss (4):
test: add test cases for new zfs module
low-level: install: check for already-existing `rpool` on install
install: config: rename option lvm_auto_rename ->
existing_storage_auto_rename
low-level: install: automatically rename existing rpools on
auto-installs
Proxmox/Install.pm | 35 +++++++++++-
Proxmox/Install/Config.pm | 6 +-
Proxmox/Sys/ZFS.pm | 20 ++++++-
proxmox-auto-installer/src/utils.rs | 2 +-
.../resources/parse_answer/disk_match.json | 2 +-
.../parse_answer/disk_match_all.json | 2 +-
.../parse_answer/disk_match_any.json | 2 +-
.../tests/resources/parse_answer/minimal.json | 2 +-
.../resources/parse_answer/nic_matching.json | 2 +-
.../resources/parse_answer/specific_nic.json | 2 +-
.../tests/resources/parse_answer/zfs.json | 2 +-
proxmox-installer-common/src/setup.rs | 2 +-
proxmox-tui-installer/src/setup.rs | 2 +-
test/Makefile | 7 ++-
test/zfs-get-pool-list.pl | 57 +++++++++++++++++++
15 files changed, 128 insertions(+), 17 deletions(-)
create mode 100755 test/zfs-get-pool-list.pl
--
2.44.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-07-11 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:57 Christoph Heiss [this message]
2024-07-11 11:57 ` [pve-devel] [PATCH installer v3 1/4] proxmox: add zfs module for retrieving importable zpool info Christoph Heiss
2024-07-11 11:57 ` [pve-devel] [PATCH installer v3 2/4] test: add test cases for new zfs module Christoph Heiss
2024-07-11 11:57 ` [pve-devel] [PATCH installer v3 3/4] install: config: rename option lvm_auto_rename -> existing_storage_auto_rename Christoph Heiss
2024-07-11 11:57 ` [pve-devel] [PATCH installer v3 4/4] low-level: install: check for already-existing `rpool` on install Christoph Heiss
2024-07-12 9:36 ` Aaron Lauterer
2024-07-15 14:49 ` Christoph Heiss
2024-07-12 9:42 ` [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool Aaron Lauterer
2024-07-15 14:52 ` Christoph Heiss
2024-07-16 8:33 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711115804.706227-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox