public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool
@ 2024-07-11  9:56 Christoph Heiss
  2024-07-11  9:56 ` [pve-devel] [PATCH installer v2 1/3] proxmox: add zfs module for retrieving importable zpool info Christoph Heiss
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Christoph Heiss @ 2024-07-11  9:56 UTC (permalink / raw)
  To: pve-devel

Pretty straight forward overall, implements a check for an existing
`rpool` on the system and ask the user whether they would like to rename
it, much in the same way as it works for VGs already.

Without this, the installer would silently create a second (and thus
conflicting) `rpool` and cause a boot failure after the installation,
since it does not know which pool to import exactly.

v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html

Notable changes v1 -> v2:
  * incorporated Aaron suggestions from v1
  * rewrote tests to use a pre-defined input instead
  * moved pool renaming to own subroutine
  * documented all new subroutines
  * split out tests into own patch

Christoph Heiss (3):
  proxmox: add zfs module for retrieving importable zpool info
  test: add test cases for new zfs module
  low-level: install: check for already-existing `rpool` on install

 Proxmox/Install.pm        |  30 +++++++++++
 Proxmox/Makefile          |   1 +
 Proxmox/Sys/ZFS.pm        | 109 ++++++++++++++++++++++++++++++++++++++
 test/Makefile             |   7 ++-
 test/zfs-get-pool-list.pl |  57 ++++++++++++++++++++
 5 files changed, 203 insertions(+), 1 deletion(-)
 create mode 100644 Proxmox/Sys/ZFS.pm
 create mode 100755 test/zfs-get-pool-list.pl

-- 
2.44.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-07-11 12:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-11  9:56 [pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool Christoph Heiss
2024-07-11  9:56 ` [pve-devel] [PATCH installer v2 1/3] proxmox: add zfs module for retrieving importable zpool info Christoph Heiss
2024-07-11  9:56 ` [pve-devel] [PATCH installer v2 2/3] test: add test cases for new zfs module Christoph Heiss
2024-07-11  9:56 ` [pve-devel] [PATCH installer v2 3/3] low-level: install: check for already-existing `rpool` on install Christoph Heiss
2024-07-11 11:31 ` [pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool Aaron Lauterer
2024-07-11 12:00 ` Christoph Heiss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal