From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI
Date: Wed, 10 Jul 2024 14:42:58 +0200 [thread overview]
Message-ID: <20240710124300.295817-1-a.lauterer@proxmox.com> (raw)
The ID for the MDS cannot start with a number [0]. The first patch adds
a check for this.
The second patch is the actual fix, by reworking the edit window when
adding new MDS'.
By allowing the users to set the name of the MDS directly, we can catch
the situation where the hostname starts with a number and let the user
decide how it should be named. Similar to what they can already do on
the CLI.
Another approach would be to leave the UI as is and catch the situation
in the backend. If an ID that starts with a number is detected, we could
prepend it with a default string.
[0] https://docs.ceph.com/en/latest/man/8/ceph-mds/
Aaron Lauterer (2):
api: ceph mds: avoid creating MDS when ID starts with number
fix#5570 ui: ceph: make MDS ID configurable
PVE/API2/Ceph/MDS.pm | 2 ++
www/manager6/ceph/ServiceList.js | 21 +++++++++++----------
2 files changed, 13 insertions(+), 10 deletions(-)
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-07-10 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 12:42 Aaron Lauterer [this message]
2024-07-10 12:42 ` [pve-devel] [PATCH manager 1/2] api: ceph mds: avoid creating MDS when ID starts with number Aaron Lauterer
2024-07-10 12:43 ` [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable Aaron Lauterer
2024-07-10 13:59 ` Christoph Heiss
2024-07-10 14:18 ` Aaron Lauterer
2024-07-10 14:24 ` Christoph Heiss
2024-07-10 13:59 ` [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI Christoph Heiss
2024-07-22 16:57 ` [pve-devel] applied-series: " Thomas Lamprecht
2024-07-23 6:52 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710124300.295817-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox