From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-guest-common v9 01/13] vzdump: common: allow 'job-id' as a parameter without being in schema
Date: Mon, 8 Jul 2024 11:38:00 +0200 [thread overview]
Message-ID: <20240708093812.164901-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20240708093812.164901-1-l.wagner@proxmox.com>
'job-id' is passed when a backup as started as a job and will be
passed to the notification system as matchable metadata. It
can be considered 'internal'.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Max Carrara <m.carrara@proxmox.com>
---
src/PVE/VZDump/Common.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 1996c5b..2532b42 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -503,7 +503,7 @@ sub command_line {
foreach my $p (keys %$param) {
next if $p eq 'id' || $p eq 'vmid' || $p eq 'starttime' ||
- $p eq 'dow' || $p eq 'stdout' || $p eq 'enabled';
+ $p eq 'dow' || $p eq 'stdout' || $p eq 'enabled' || $p eq 'job-id';
my $v = $param->{$p};
my $pd = $confdesc->{$p} || die "no such vzdump option '$p'\n";
if ($p eq 'exclude-path') {
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-08 9:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 9:37 [pve-devel] [PATCH many v9 00/13] notifications: notification metadata matching improvements Lukas Wagner
2024-07-08 9:38 ` Lukas Wagner [this message]
2024-07-22 17:12 ` [pve-devel] applied: [PATCH pve-guest-common v9 01/13] vzdump: common: allow 'job-id' as a parameter without being in schema Thomas Lamprecht
2024-07-08 9:38 ` [pve-devel] [PATCH manager v9 02/13] api: jobs: vzdump: pass job 'job-id' parameter Lukas Wagner
2024-07-22 17:34 ` [pve-devel] applied: " Thomas Lamprecht
2024-07-08 9:38 ` [pve-devel] [PATCH manager v9 03/13] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH manager v9 04/13] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH manager v9 05/13] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH manager v9 06/13] d/control: bump proxmox-widget-toolkit dependency to 4.1.4 Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH widget-toolkit v9 07/13] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH widget-toolkit v9 08/13] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH widget-toolkit v9 09/13] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH widget-toolkit v9 10/13] notification: matcher: move match-severity " Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH docs v9 11/13] notifications: describe new notification metadata fields Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH docs v9 12/13] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner
2024-07-08 9:38 ` [pve-devel] [PATCH docs v9 13/13] notifications: add note regarding when 'job-id' is set for backups Lukas Wagner
2024-07-22 17:36 ` [pve-devel] partially-applied: [PATCH many v9 00/13] notifications: notification metadata matching improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708093812.164901-2-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox