[pve-devel] [PATCH pve-manager] www: backup: clarify experimental change detection modes

[pve-devel] [PATCH pve-manager] www: backup: clarify experimental change detection modes

[Christian Ebner]

Currently, the whole mode selector is labeled as experimental, this
does however give the impression that also the default legacy mode is
an experimental mode.
To clarify that only the `data` and `metadata` change detection modes
are experimental, move the experimental label to the individual
modes and explicitly mention the experimental modes in the message.

Also, make it more clear that the archive encoding format depends on
the selected mode.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/manager6/panel/BackupAdvancedOptions.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index 7dd19f96..f6822c0a 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -249,14 +249,14 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 		value: '__default__',
 		comboItems: [
 		    ['__default__', "Default"],
-		    ['data', "Data"],
-		    ['metadata', "Metadata"],
+		    ['data', "Data (experimental)"],
+		    ['metadata', "Metadata (experimental)"],
 		],
 	    },
 	    endFlex: 2,
 	    endColumn: {
 		xtype: 'displayfield',
-		value: gettext("EXPERIMENTAL: Mode to detect file changes and archive encoding format for container backups."),
+		value: gettext("Mode to detect file changes and switch archive encoding format for container backups (NOTE: `data` and `metadata` modes are experimental)."),
 	    },
 	},
 	{
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-manager] www: backup: clarify experimental change detection modes

[Thomas Lamprecht]

Am 26/06/2024 um 09:00 schrieb Christian Ebner:
> Currently, the whole mode selector is labeled as experimental, this
> does however give the impression that also the default legacy mode is
> an experimental mode.
> To clarify that only the `data` and `metadata` change detection modes
> are experimental, move the experimental label to the individual
> modes and explicitly mention the experimental modes in the message.
> 
> Also, make it more clear that the archive encoding format depends on
> the selected mode.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  www/manager6/panel/BackupAdvancedOptions.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

Just for the record: This was already applied by Fabian [0], thanks!

[0]: https://git.proxmox.com/?p=pve-manager.git;a=commit;h=8504a0e29132e01101a28f9dafcc930fd6cab95d


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel