public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension
@ 2024-06-14 11:29 Fiona Ebner
  2024-06-14 11:29 ` [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore Fiona Ebner
  2024-07-03 12:34 ` [pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Fiona Ebner @ 2024-06-14 11:29 UTC (permalink / raw)
  To: pve-devel

While archives with unknown or undetermined subtype could be shown,
this is only for autocompletion, so users can still specify those
manually if required.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7815b608..fe23d4b9 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -8592,7 +8592,7 @@ sub complete_backup_archives {
     my $res = [];
     foreach my $id (keys %$data) {
 	foreach my $item (@{$data->{$id}}) {
-	    next if $item->{format} !~ m/^vma\.(${\PVE::Storage::Plugin::COMPRESSOR_RE})$/;
+	    next if ($item->{subtype} // '') ne 'qemu';
 	    push @$res, $item->{volid} if defined($item->{volid});
 	}
     }
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore
  2024-06-14 11:29 [pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Fiona Ebner
@ 2024-06-14 11:29 ` Fiona Ebner
  2024-07-03 12:34 ` [pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2024-06-14 11:29 UTC (permalink / raw)
  To: pve-devel

While archives with unknown or undetermined subtype could be shown,
this is only for autocompletion, so users can still specify those
manually if required.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 65d0fa8..e154efe 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2341,6 +2341,7 @@ sub complete_os_templates {
     my $res = [];
     foreach my $id (keys %$data) {
 	foreach my $item (@{$data->{$id}}) {
+	    next if $vtype eq 'backup' && ($item->{subtype} // '') ne 'lxc';
 	    push @$res, $item->{volid} if defined($item->{volid});
 	}
     }
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension
  2024-06-14 11:29 [pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Fiona Ebner
  2024-06-14 11:29 ` [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore Fiona Ebner
@ 2024-07-03 12:34 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-07-03 12:34 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fiona Ebner

Am 14/06/2024 um 13:29 schrieb Fiona Ebner:
> While archives with unknown or undetermined subtype could be shown,
> this is only for autocompletion, so users can still specify those
> manually if required.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-03 12:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-14 11:29 [pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Fiona Ebner
2024-06-14 11:29 ` [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore Fiona Ebner
2024-07-03 12:34 ` [pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal