From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/4] tui: make disk options view tabbed on small screens
Date: Thu, 13 Jun 2024 13:53:09 +0200 [thread overview]
Message-ID: <20240613115318.842583-1-c.heiss@proxmox.com> (raw)
This adds a tabbed view component, for usage in the advanced disk
options dialog when selecting ZFS or Btrfs. Works pretty much the same
as its GUI counterpart, as much as that is possible.
It's currently only activated for small (<=80 columns) displays, to make
disk selection a lot more usable in these cases. This mostly affects
serial console installation, but possibly also installations using a
virtual screen via IPMI/BMC.
Testing can be done using the `stty` to set specific terminal sizes,
e.g. `stty columns 80 rows 24` for a standard VT100-spec terminal.
This componont/view may also be made the default for the advanced disk
options dialog, to align the TUI with it GUI in more cases - I'm open
for discussion on that. Would also simplify the code a lot, so there
are certainly other benefits to it as well.
Christoph Heiss (4):
tui: fix some comment typos
tui: bootdisk: align btrfs dialog interface with zfs equivalent
tui: views: add new TabbedView component
tui: bootdisk: use tabbed view for disk options on small screens
proxmox-tui-installer/src/views/bootdisk.rs | 260 +++++++++++-------
proxmox-tui-installer/src/views/mod.rs | 3 +
.../src/views/tabbed_view.rs | 196 +++++++++++++
3 files changed, 358 insertions(+), 101 deletions(-)
create mode 100644 proxmox-tui-installer/src/views/tabbed_view.rs
--
2.44.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-06-13 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 11:53 Christoph Heiss [this message]
2024-06-13 11:53 ` [pve-devel] [PATCH installer 1/4] tui: fix some comment typos Christoph Heiss
2024-06-13 11:53 ` [pve-devel] [PATCH installer 2/4] tui: bootdisk: align btrfs dialog interface with zfs equivalent Christoph Heiss
2024-06-13 11:53 ` [pve-devel] [PATCH installer 3/4] tui: views: add new TabbedView component Christoph Heiss
2024-06-13 11:53 ` [pve-devel] [PATCH installer 4/4] tui: bootdisk: use tabbed view for disk options on small screens Christoph Heiss
2024-07-02 16:49 ` [pve-devel] [PATCH installer 0/4] tui: make disk options view tabbed " Max Carrara
2024-07-04 9:05 ` Christoph Heiss
2024-07-04 9:28 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613115318.842583-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox