From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v4 pve-manager 3/4] www: advanced backup: add pbs change detection mode selector
Date: Mon, 10 Jun 2024 11:57:45 +0200 [thread overview]
Message-ID: <20240610095746.203328-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20240610095746.203328-1-c.ebner@proxmox.com>
The proxmox backup client allows to switch the method used to encode
data based on a change-detection-mode parameter. Expose this setting
as experimental feature in the advanced panel for a backup job.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 3:
- drop default value on set
www/manager6/panel/BackupAdvancedOptions.js | 23 +++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index 1026c6f4..7dd19f96 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -97,6 +97,9 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
}
delete values.fleecing;
}
+ if (values["pbs-change-detection-mode"] === '__default__') {
+ delete values["pbs-change-detection-mode"];
+ }
return values;
},
@@ -236,6 +239,26 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
value: gettext("Run jobs as soon as possible if they couldn't start on schedule, for example, due to the node being offline."),
},
},
+ {
+ xtype: 'pveTwoColumnContainer',
+ startColumn: {
+ xtype: 'proxmoxKVComboBox',
+ fieldLabel: gettext('PBS change detection mode'),
+ name: 'pbs-change-detection-mode',
+ deleteEmpty: true,
+ value: '__default__',
+ comboItems: [
+ ['__default__', "Default"],
+ ['data', "Data"],
+ ['metadata', "Metadata"],
+ ],
+ },
+ endFlex: 2,
+ endColumn: {
+ xtype: 'displayfield',
+ value: gettext("EXPERIMENTAL: Mode to detect file changes and archive encoding format for container backups."),
+ },
+ },
{
xtype: 'component',
padding: '5 1',
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-06-10 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 9:57 [pve-devel] [PATCH v4 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS Christian Ebner
2024-06-10 9:57 ` [pve-devel] [PATCH v4 pve-guest-common 1/4] vzdump: add PBS change detection mode configuration Christian Ebner
2024-06-10 9:57 ` [pve-devel] [PATCH v4 pve-container 2/4] vzdump: conditionally set PBS change detection mode option Christian Ebner
2024-06-10 9:57 ` Christian Ebner [this message]
2024-06-10 9:57 ` [pve-devel] [PATCH v4 pve-manager 4/4] vzdump: add pbs-change-detection-mode to config template Christian Ebner
2024-06-10 12:06 ` [pve-devel] applied-series: [PATCH v4 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610095746.203328-4-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox