* [pve-devel] [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support
@ 2024-06-04 8:34 Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 1/2] setup: support Ubuntu 24.04 Noble Christoph Heiss
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christoph Heiss @ 2024-06-04 8:34 UTC (permalink / raw)
To: pve-devel
This backports the series to support Ubuntu 24.04 "Noble" CTs [0].
They could be cherry-picked cleanly. Tested on a up-to-date PVE 7.4
system (running on `pvetest`), template for Ubuntu 24.04
(`ubuntu-24.04-standard_24.04-2_amd64.tar.zst`) was copied from a 8.2
host for testing.
Tested creating new CT from that template, using either a static IP or
DHCP. Then working around with the system a bit, everything seems to
work just fine.
[0] https://lists.proxmox.com/pipermail/pve-devel/2024-April/063766.html
Fiona Ebner (2):
setup: support Ubuntu 24.04 Noble
setup: unlink default netplan configuration even with Ubuntu >= 23.04
src/PVE/LXC/Setup/Ubuntu.pm | 3 +++
1 file changed, 3 insertions(+)
--
2.44.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH stable-7 container 1/2] setup: support Ubuntu 24.04 Noble
2024-06-04 8:34 [pve-devel] [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Christoph Heiss
@ 2024-06-04 8:34 ` Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04 Christoph Heiss
2024-06-04 10:48 ` [pve-devel] applied-series: [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Heiss @ 2024-06-04 8:34 UTC (permalink / raw)
To: pve-devel
From: Fiona Ebner <f.ebner@proxmox.com>
Minimally tested, that an upgrade from an existing 23.04 container
works, there still is network and no obviously bad messages in the
container's journal.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
(cherry picked from commit 3d800f832c25e4bf2435d88ab190fd8e681a67b1)
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
src/PVE/LXC/Setup/Ubuntu.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index 905cacb..cea8ef5 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -12,6 +12,7 @@ use PVE::LXC::Setup::Debian;
use base qw(PVE::LXC::Setup::Debian);
my $known_versions = {
+ '24.04' => 1, # noble
'23.10' => 1, # mantic
'23.04' => 1, # lunar
'22.10' => 1, # kinetic
--
2.44.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH stable-7 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04
2024-06-04 8:34 [pve-devel] [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 1/2] setup: support Ubuntu 24.04 Noble Christoph Heiss
@ 2024-06-04 8:34 ` Christoph Heiss
2024-06-04 10:48 ` [pve-devel] applied-series: [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Heiss @ 2024-06-04 8:34 UTC (permalink / raw)
To: pve-devel
From: Fiona Ebner <f.ebner@proxmox.com>
It seems like commit 02d9462 ("setup: enable systemd-networkd via
preset for ubuntu 23.04+") also resulted in the default netplan
configuration no longer being unlinked. That should still happen, even
if systemd-networkd is now enabled via preset. Otherwise, the network
configuration created by Proxmox VE is not ordered before the one
generated by netplan and thus not applied by systemd-networkd.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/post-658058
Fixes: 02d9462 ("setup: enable systemd-networkd via preset for ubuntu 23.04+")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
(cherry picked from commit dfcbad017361d4e3ded20af573fbaeacc05231eb)
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
src/PVE/LXC/Setup/Ubuntu.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index cea8ef5..897eab9 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -73,7 +73,9 @@ sub template_fixup {
'/etc/systemd/system/multi-user.target.wants/systemd-networkd.service');
$self->ct_symlink('/lib/systemd/system/systemd-networkd.socket',
'/etc/systemd/system/socket.target.wants/systemd-networkd.socket');
+ }
+ if ($version >= '17.10') {
# unlink default netplan lxc config
$self->ct_unlink('/etc/netplan/10-lxc.yaml');
}
--
2.44.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied-series: [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support
2024-06-04 8:34 [pve-devel] [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 1/2] setup: support Ubuntu 24.04 Noble Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04 Christoph Heiss
@ 2024-06-04 10:48 ` Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2024-06-04 10:48 UTC (permalink / raw)
To: Proxmox VE development discussion, Christoph Heiss
Am 04/06/2024 um 10:34 schrieb Christoph Heiss:
> This backports the series to support Ubuntu 24.04 "Noble" CTs [0].
>
> They could be cherry-picked cleanly. Tested on a up-to-date PVE 7.4
> system (running on `pvetest`), template for Ubuntu 24.04
> (`ubuntu-24.04-standard_24.04-2_amd64.tar.zst`) was copied from a 8.2
> host for testing.
>
> Tested creating new CT from that template, using either a static IP or
> DHCP. Then working around with the system a bit, everything seems to
> work just fine.
>
> [0] https://lists.proxmox.com/pipermail/pve-devel/2024-April/063766.html
>
> Fiona Ebner (2):
> setup: support Ubuntu 24.04 Noble
> setup: unlink default netplan configuration even with Ubuntu >= 23.04
>
> src/PVE/LXC/Setup/Ubuntu.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-04 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-04 8:34 [pve-devel] [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 1/2] setup: support Ubuntu 24.04 Noble Christoph Heiss
2024-06-04 8:34 ` [pve-devel] [PATCH stable-7 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04 Christoph Heiss
2024-06-04 10:48 ` [pve-devel] applied-series: [PATCH stable-7 container 0/2] setup: cherry-pick ubuntu 24.04 support Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox