From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage v2 1/1] esxi: improve error handling for fuse mount tool
Date: Fri, 10 May 2024 15:56:58 +0200 [thread overview]
Message-ID: <20240510135658.3519714-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20240510135658.3519714-1-d.csapak@proxmox.com>
if the fuse tool encounters an error early, it prints it like:
Error: some error message
on stderr.
Redirect STDERR of the child process (which mounts the ESXi instance) to
the pipe of the parent (API) process, so that it can pass a hopefully
more meaningful message to the user than just an erroneous return code.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/Storage/ESXiPlugin.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index b8bce0e..4bcd7ff 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -222,6 +222,9 @@ sub esxi_mount : prototype($$$;$) {
// die "failed to get file descriptor flags: $!\n";
fcntl($wr, F_SETFD, $flags & ~FD_CLOEXEC)
// die "failed to remove CLOEXEC flag from fd: $!\n";
+
+ open(STDERR, ">&", $wr) or die "unable to redirect STDERR: $!\n";
+
# FIXME: use the user/group options!
exec {$ESXI_FUSE_TOOL}
$ESXI_FUSE_TOOL,
@@ -245,7 +248,7 @@ sub esxi_mount : prototype($$$;$) {
undef $wr;
my $result = do { local $/ = undef; <$rd> };
- if ($result =~ /^ERROR: (.*)$/) {
+ if ($result =~ /^ERROR: (.*)$/i) {
die "$1\n";
}
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-05-10 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 13:56 [pve-devel] [PATCH pve-esxi-import-tools/storage v2] improve error handling/logging Dominik Csapak
2024-05-10 13:56 ` [pve-devel] [PATCH pve-esxi-import-tools v2 1/1] improve error handling before mounting Dominik Csapak
2024-05-10 13:56 ` Dominik Csapak [this message]
2024-06-07 11:27 ` [pve-devel] applied: [PATCH pve-esxi-import-tools/storage v2] improve error handling/logging Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510135658.3519714-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox