public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear
Date: Wed,  8 May 2024 14:54:18 +0200	[thread overview]
Message-ID: <20240508125418.2598112-1-d.csapak@proxmox.com> (raw)

'MDev' could be interpreted as either 'Mediated Device' or 'Mapped
Device', which can confuse users.

At least one user was confused:
https://forum.proxmox.com/threads/146586/#post-662091

Fix that by writing out 'Mediated Device'.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
sending as RFC because the text is now too long for one line, which is
bad IMHO, but I could not come up with a better text that fits, maybe
someone else has a better idea (or we leave it as is)


 www/manager6/qemu/PCIEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index 8cef1b10..940e017c 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -262,7 +262,7 @@ Ext.define('PVE.qemu.PCIInputPanel', {
 		name: 'mdev',
 		reference: 'mdev',
 		disabled: true,
-		fieldLabel: gettext('MDev Type'),
+		fieldLabel: gettext('Mediated Device Type'),
 		nodename: me.nodename,
 		listeners: {
 		    change: function(field, value) {
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2024-05-08 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 12:54 Dominik Csapak [this message]
2024-05-08 15:00 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508125418.2598112-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal