public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI
Date: Tue, 30 Apr 2024 17:28:49 +0200	[thread overview]
Message-ID: <20240430152857.659326-1-m.carrara@proxmox.com> (raw)

Ceph Build Commit in UI - Version 1
===================================

This series adds Ceph's build commit to the UI and lets the user know if
a service is running an outdated build and therefore ought to be
restarted.

The build commit is now displayed next to the version for all Ceph
services like so:

  18.2.2 (abcd1234)

Should a service run an outdated build, the new build commit is also
displayed:

  18.2.2 (abcd1234 -> 5678fedc)

(Icons are omitted here).

See the individual patches for more in-depth information.

Additionally, some of the code was also cleaned up and refactored a
little along the way.

I'm not 100% sure if the design I've opted for here is the best, so it
would be great to get some opinions on this. The OSD tree/list view
especially can get a little noisy if there are a lot of outdated OSDs
running.

Summary of Changes
------------------

Max Carrara (8):
  ceph: tools: refactor installation check as guard clause
  ceph: tools: update Ceph version regex
  ceph: services: remove old cluster broadcast
  ceph: services: refactor version existence check as guard clause
  utils: align regex of parse_ceph_version with Perl equivalent
  ui: ceph: services: parse and display build commit
  api: ceph: add build commit of host to Ceph osd index endpoint data
  ui: ceph: osd: rework rendering of version field & show build commit

 PVE/API2/Ceph/OSD.pm             |  1 +
 PVE/Ceph/Services.pm             | 38 +++++++++++-----------
 PVE/Ceph/Tools.pm                | 48 +++++++++++++++++-----------
 www/manager6/Utils.js            | 17 +++++++++-
 www/manager6/ceph/OSD.js         | 55 ++++++++++++++++++++++++++------
 www/manager6/ceph/ServiceList.js | 34 +++++++++++++++-----
 www/manager6/ceph/Services.js    | 14 +++++++-
 7 files changed, 149 insertions(+), 58 deletions(-)

-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2024-04-30 15:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 15:28 Max Carrara [this message]
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 1/8] ceph: tools: refactor installation check as guard clause Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 2/8] ceph: tools: update Ceph version regex Max Carrara
2024-06-05 14:48   ` Lukas Wagner
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 3/8] ceph: services: remove old cluster broadcast Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 4/8] ceph: services: refactor version existence check as guard clause Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 5/8] utils: align regex of parse_ceph_version with Perl equivalent Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 6/8] ui: ceph: services: parse and display build commit Max Carrara
2024-06-05 14:48   ` Lukas Wagner
2024-06-06  8:04     ` Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 7/8] api: ceph: add build commit of host to Ceph osd index endpoint data Max Carrara
2024-04-30 15:28 ` [pve-devel] [PATCH v1 pve-manager 8/8] ui: ceph: osd: rework rendering of version field & show build commit Max Carrara
2024-06-05 14:48   ` Lukas Wagner
2024-06-06  8:04     ` Max Carrara
2024-06-05  9:16 ` [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI Max Carrara
2024-06-05 14:48 ` Lukas Wagner
2024-06-06  8:06   ` Max Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430152857.659326-1-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal