* [pve-devel] [PATCH installer 0/2] fix 2 cosmetic glitches with the tests.
@ 2024-04-30 15:18 Stoiko Ivanov
2024-04-30 15:18 ` [pve-devel] [PATCH installer 1/2] d/control: add geoip-bin to Build-Depends Stoiko Ivanov
2024-04-30 15:18 ` [pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn Stoiko Ivanov
0 siblings, 2 replies; 3+ messages in thread
From: Stoiko Ivanov @ 2024-04-30 15:18 UTC (permalink / raw)
To: pve-devel
while testing a patch-series today I saw quite a few:
```
Use of uninitialized value...
```
warnings from running the tests. While the issues are cosmetic, and don't
harm, the actual build - they were enough to distract me for 10 minutes,
which I want to spare others (including my future self).
Stoiko Ivanov (2):
d/control: add geoip-bin to Build-Depends
tests: prevent uninitialized value warning with undef as fqdn
debian/control | 1 +
test/parse-fqdn.pl | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH installer 1/2] d/control: add geoip-bin to Build-Depends
2024-04-30 15:18 [pve-devel] [PATCH installer 0/2] fix 2 cosmetic glitches with the tests Stoiko Ivanov
@ 2024-04-30 15:18 ` Stoiko Ivanov
2024-04-30 15:18 ` [pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn Stoiko Ivanov
1 sibling, 0 replies; 3+ messages in thread
From: Stoiko Ivanov @ 2024-04-30 15:18 UTC (permalink / raw)
To: pve-devel
else the tests running:
`./proxmox-low-level-installer -t test.img dump-env`
print quite a few warnings about the use of uninitialized values
(though they still continue happily).
This was a slight distraction for me.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index eb4d3be..afe3c70 100644
--- a/debian/control
+++ b/debian/control
@@ -4,6 +4,7 @@ Priority: optional
Maintainer: Proxmox Support Team <support@proxmox.com>
Build-Depends: cargo:native,
debhelper-compat (= 12),
+ geoip-bin,
iproute2,
iso-codes,
libgtk3-perl,
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn
2024-04-30 15:18 [pve-devel] [PATCH installer 0/2] fix 2 cosmetic glitches with the tests Stoiko Ivanov
2024-04-30 15:18 ` [pve-devel] [PATCH installer 1/2] d/control: add geoip-bin to Build-Depends Stoiko Ivanov
@ 2024-04-30 15:18 ` Stoiko Ivanov
1 sibling, 0 replies; 3+ messages in thread
From: Stoiko Ivanov @ 2024-04-30 15:18 UTC (permalink / raw)
To: pve-devel
cosmetic issue - but was distracting enough to make me look if there's
an error.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
test/parse-fqdn.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/parse-fqdn.pl b/test/parse-fqdn.pl
index 6638fbe..47e0e21 100755
--- a/test/parse-fqdn.pl
+++ b/test/parse-fqdn.pl
@@ -24,9 +24,10 @@ sub is_parsed {
sub is_invalid {
my ($fqdn, $expected_err) = @_;
+ my $print_fqdn = $fqdn // '(undefined)';
my $parsed = eval { parse_fqdn($fqdn) };
- is($parsed, undef, "invalid FQDN did fail parsing: $fqdn");
- is($@, $expected_err, "invalid FQDN threw correct error: $fqdn");
+ is($parsed, undef, "invalid FQDN did fail parsing: $print_fqdn");
+ is($@, $expected_err, "invalid FQDN threw correct error: $print_fqdn");
}
is_invalid(undef, ERR_EMPTY);
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-30 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30 15:18 [pve-devel] [PATCH installer 0/2] fix 2 cosmetic glitches with the tests Stoiko Ivanov
2024-04-30 15:18 ` [pve-devel] [PATCH installer 1/2] d/control: add geoip-bin to Build-Depends Stoiko Ivanov
2024-04-30 15:18 ` [pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn Stoiko Ivanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox