[pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Fiona Ebner]

Reported in the community forum:
https://forum.proxmox.com/threads/145848/#post-658694

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Minimally tested, that an upgrade from an existing 23.04 container
works, there still is network and no obviously bad messages in the
container's journal.

 src/PVE/LXC/Setup/Ubuntu.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index 905cacb..cea8ef5 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -12,6 +12,7 @@ use PVE::LXC::Setup::Debian;
 use base qw(PVE::LXC::Setup::Debian);
 
 my $known_versions = {
+    '24.04' => 1, # noble
     '23.10' => 1, # mantic
     '23.04' => 1, # lunar
     '22.10' => 1, # kinetic
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Fiona Ebner]

Am 29.04.24 um 11:23 schrieb Fiona Ebner:
> Reported in the community forum:
> https://forum.proxmox.com/threads/145848/#post-658694
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Minimally tested, that an upgrade from an existing 23.04 container
> works, there still is network and no obviously bad messages in the
> container's journal.
> 

Hmm, while the upgrade did work, starting from an Ubuntu 24.04 template
and setting a static IP does not seem to work, like described here:
https://forum.proxmox.com/threads/145848/post-658058


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Fiona Ebner]

Am 29.04.24 um 11:36 schrieb Fiona Ebner:
> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/145848/#post-658694
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Minimally tested, that an upgrade from an existing 23.04 container
>> works, there still is network and no obviously bad messages in the
>> container's journal.
>>
> 
> Hmm, while the upgrade did work, starting from an Ubuntu 24.04 template
> and setting a static IP does not seem to work, like described here:
> https://forum.proxmox.com/threads/145848/post-658058

Seems like the ordering of the configuration files is the issue. The
following would fix it, but probably needs to be special-cased for new
Ubuntu (or new systemd, would still need to check where the change came
in exactly) not to mess up existing containers, right?

> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> index 084b039..162498a 100644
> --- a/src/PVE/LXC/Setup/Base.pm
> +++ b/src/PVE/LXC/Setup/Base.pm
> @@ -249,7 +249,7 @@ sub setup_systemd_networkd {
>         my $d = PVE::LXC::Config->parse_lxc_network($conf->{$k});
>         next if !$d->{name};
>  
> -       my $filename = "/etc/systemd/network/$d->{name}.network";
> +       my $filename = "/etc/systemd/network/10-$d->{name}.network";
>  
>         my $data = <<"DATA";
>  [Match]


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Thomas Lamprecht]

Am 29/04/2024 um 11:56 schrieb Fiona Ebner:
> Am 29.04.24 um 11:36 schrieb Fiona Ebner:
>> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
>>> Reported in the community forum:
>>> https://forum.proxmox.com/threads/145848/#post-658694
>>>
>>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>>> ---
>>>
>>> Minimally tested, that an upgrade from an existing 23.04 container
>>> works, there still is network and no obviously bad messages in the
>>> container's journal.
>>>
>> Hmm, while the upgrade did work, starting from an Ubuntu 24.04 template
>> and setting a static IP does not seem to work, like described here:
>> https://forum.proxmox.com/threads/145848/post-658058
>
> Seems like the ordering of the configuration files is the issue. The
> following would fix it, but probably needs to be special-cased for new
> Ubuntu (or new systemd, would still need to check where the change came
> in exactly) not to mess up existing containers, right?

Yes, at least that would reduce regression potential of unknown issues.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Fiona Ebner]

Am 29.04.24 um 13:11 schrieb Thomas Lamprecht:
> Am 29/04/2024 um 11:56 schrieb Fiona Ebner:
>> Am 29.04.24 um 11:36 schrieb Fiona Ebner:
>>> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
>>>> Reported in the community forum:
>>>> https://forum.proxmox.com/threads/145848/#post-658694
>>>>
>>>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>>>> ---
>>>>
>>>> Minimally tested, that an upgrade from an existing 23.04 container
>>>> works, there still is network and no obviously bad messages in the
>>>> container's journal.
>>>>
>>> Hmm, while the upgrade did work, starting from an Ubuntu 24.04 template
>>> and setting a static IP does not seem to work, like described here:
>>> https://forum.proxmox.com/threads/145848/post-658058
>>
>> Seems like the ordering of the configuration files is the issue. The
>> following would fix it, but probably needs to be special-cased for new
>> Ubuntu (or new systemd, would still need to check where the change came
>> in exactly) not to mess up existing containers, right?
> 
> Yes, at least that would reduce regression potential of unknown issues.

So this is not new (already present for Ubuntu 23.10) and stems from the
fact that these images from linuxcontainers.org contain:

> root@CT113:~# cat /etc/netplan/10-lxc.yaml 
> network:
>   version: 2
>   ethernets:
>     eth0:
>       dhcp4: true
>       dhcp-identifier: mac

and that generates a configuration that will be ordered before
ours/preferred by systemd-networkd:

> root@CT113:~# networkctl status eth0
> ● 2: eth0                                                                      
>                      Link File: n/a
>                   Network File: /run/systemd/network/10-netplan-eth0.network

Should we still change something in the setup code? I suppose our
template will not have the netplan configuration file and in a way it'd
just be a race to the bottom of being ordered first.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Thomas Lamprecht]

On 30/04/2024 10:43, Fiona Ebner wrote:
> So this is not new (already present for Ubuntu 23.10) and stems from the
> fact that these images from linuxcontainers.org contain:
> 
>> root@CT113:~# cat /etc/netplan/10-lxc.yaml 
>> network:
>>   version: 2
>>   ethernets:
>>     eth0:
>>       dhcp4: true
>>       dhcp-identifier: mac
> 
> and that generates a configuration that will be ordered before
> ours/preferred by systemd-networkd:
> 
>> root@CT113:~# networkctl status eth0
>> ● 2: eth0                                                                      
>>                      Link File: n/a
>>                   Network File: /run/systemd/network/10-netplan-eth0.network
> 
> Should we still change something in the setup code? I suppose our
> template will not have the netplan configuration file and in a way it'd
> just be a race to the bottom of being ordered first.

Why should there be a incentive for a race to the bottom?

If we have users running into this then yes, we should do something
about it, we do not have a hard requirement of the Ubuntu templates
being build through DAB and especially as we use the LXC template
builder (or well its artefacts) for other non-Debian images, I'd
see why users take it as a source.

If the change in ordering is the correct solution I cannot say without
looking into all deeper – but I'm sure you can evaluate that.
One possibility might be disabling netplan on CT creation, if PVE wants
to control network in another way itself.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

[Fiona Ebner]

Am 30.04.24 um 10:59 schrieb Thomas Lamprecht:
> On 30/04/2024 10:43, Fiona Ebner wrote:
>> So this is not new (already present for Ubuntu 23.10) and stems from the
>> fact that these images from linuxcontainers.org contain:
>>
>>> root@CT113:~# cat /etc/netplan/10-lxc.yaml 
>>> network:
>>>   version: 2
>>>   ethernets:
>>>     eth0:
>>>       dhcp4: true
>>>       dhcp-identifier: mac
>>
>> and that generates a configuration that will be ordered before
>> ours/preferred by systemd-networkd:
>>
>>> root@CT113:~# networkctl status eth0
>>> ● 2: eth0                                                                      
>>>                      Link File: n/a
>>>                   Network File: /run/systemd/network/10-netplan-eth0.network
>>
>> Should we still change something in the setup code? I suppose our
>> template will not have the netplan configuration file and in a way it'd
>> just be a race to the bottom of being ordered first.
> 
> Why should there be a incentive for a race to the bottom?
> 

What I mean is that template creators also have an incentive to order
their configurations very early. And we have the incentive to order even
earlier. But yes, "race" was the wrong word, because they do not have an
incentive to order earlier than us.

> If we have users running into this then yes, we should do something
> about it, we do not have a hard requirement of the Ubuntu templates
> being build through DAB and especially as we use the LXC template
> builder (or well its artefacts) for other non-Debian images, I'd
> see why users take it as a source.
> 
> If the change in ordering is the correct solution I cannot say without
> looking into all deeper – but I'm sure you can evaluate that.
> One possibility might be disabling netplan on CT creation, if PVE wants
> to control network in another way itself.

I'll look into disabling netplan on creation. That sounds like a cleaner
solution.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel