[pve-devel] [PATCH installer] auto-installer: fix answer-request charset

[pve-devel] [PATCH installer] auto-installer: fix answer-request charset

[Fabian Grünbichler]

'utf-' is a typo, and can trip up some servers that do strict
checking/matching.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/

 proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs b/proxmox-fetch-answer/src/fetch_plugins/http.rs
index 1c5e9ea..21bc6a2 100644
--- a/proxmox-fetch-answer/src/fetch_plugins/http.rs
+++ b/proxmox-fetch-answer/src/fetch_plugins/http.rs
@@ -211,7 +211,7 @@ mod http_post {
 
             answer = agent
                 .post(&url)
-                .set("Content-type", "application/json; charset=utf-")
+                .set("Content-type", "application/json; charset=utf-8")
                 .send_string(&payload)?
                 .into_string()?;
         } else {
@@ -231,7 +231,7 @@ mod http_post {
                 .build();
             answer = agent
                 .post(&url)
-                .set("Content-type", "application/json; charset=utf-")
+                .set("Content-type", "application/json; charset=utf-8")
                 .timeout(std::time::Duration::from_secs(60))
                 .send_string(&payload)?
                 .into_string()?;
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] auto-installer: fix answer-request charset

[Christoph Heiss]

Important fix, apparently slipped through in April.
"Re-discovered" it yesterday by coincidence while talking to Aaron.

On Fri, Apr 26, 2024 at 10:12:55AM GMT, Fabian Grünbichler wrote:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>

> ---
>
> Notes:
>     see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/
>
>  proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs b/proxmox-fetch-answer/src/fetch_plugins/http.rs
> index 1c5e9ea..21bc6a2 100644
> --- a/proxmox-fetch-answer/src/fetch_plugins/http.rs
> +++ b/proxmox-fetch-answer/src/fetch_plugins/http.rs
> @@ -211,7 +211,7 @@ mod http_post {
>
>              answer = agent
>                  .post(&url)
> -                .set("Content-type", "application/json; charset=utf-")
> +                .set("Content-type", "application/json; charset=utf-8")
>                  .send_string(&payload)?
>                  .into_string()?;
>          } else {
> @@ -231,7 +231,7 @@ mod http_post {
>                  .build();
>              answer = agent
>                  .post(&url)
> -                .set("Content-type", "application/json; charset=utf-")
> +                .set("Content-type", "application/json; charset=utf-8")
>                  .timeout(std::time::Duration::from_secs(60))
>                  .send_string(&payload)?
>                  .into_string()?;
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH installer] auto-installer: fix answer-request charset

[Thomas Lamprecht]

Am 26/04/2024 um 10:12 schrieb Fabian Grünbichler:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     see https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/
> 
>  proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, with Christoph's R-b, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel