public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: fix align mode of two column container
Date: Wed, 24 Apr 2024 13:39:45 +0200	[thread overview]
Message-ID: <20240424113945.2252953-1-d.csapak@proxmox.com> (raw)

'stretch' is most often the wrong value, as that will stretch
everything, to the height of the whole container, including fields.
That is not desirable, since fields look not good when stretched this
way (e.g. the controls are not correctly aligned).

To fix it, simply set it to 'begin'.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
noticed that the 'zstd thread' field was strechted in the backup
advanced panel when using the german language...

 www/manager6/container/TwoColumnContainer.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/container/TwoColumnContainer.js b/www/manager6/container/TwoColumnContainer.js
index e8e5fca9..b7bf735a 100644
--- a/www/manager6/container/TwoColumnContainer.js
+++ b/www/manager6/container/TwoColumnContainer.js
@@ -10,7 +10,7 @@ Ext.define('PVE.container.TwoColumnContainer', {
 
     layout: {
 	type: 'hbox',
-	align: 'stretch',
+	align: 'begin',
     },
 
     // The default ratio of the start widget. It an be an integer or a floating point number
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2024-04-24 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 11:39 Dominik Csapak [this message]
2024-06-12 13:57 ` [pve-devel] applied: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424113945.2252953-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal