From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: backup job editor: fix disable behavior for fleecing storage
Date: Tue, 23 Apr 2024 14:15:00 +0200 [thread overview]
Message-ID: <20240423121500.2460620-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20240423121500.2460620-1-d.csapak@proxmox.com>
commit
569b0388 (ui: fix reset behavior of backup job editor)
disabled the fleecint storage field by default (as that is the default
state) to fix the reset behavior. This broke editing the job when
fleecing was enabled and the user did not navigate to the advanced tab
yet.
It seems that the 'bind' here only gets triggered once the panel is
rendered, but we actually need it before that.
To work around the issue for now, manually enable/disable the field when
toggling the fleecing checkbox. (Though this warrants a bit of deeper
investigation into this bind behavior)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/panel/BackupAdvancedOptions.js | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index f1810637..650946fe 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -18,6 +18,17 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
controller: {
xclass: 'Ext.app.ViewController',
+
+ toggleFleecing: function(cb, value) {
+ let me = this;
+ me.lookup('fleecingStorage').setDisabled(!value);
+ },
+
+ control: {
+ 'proxmoxcheckbox[reference=fleecingEnabled]': {
+ change: 'toggleFleecing',
+ },
+ }
},
onGetValues: function(formValues) {
@@ -181,14 +192,11 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
xtype: 'pveStorageSelector',
name: 'fleecing-storage',
fieldLabel: gettext('Fleecing Storage'),
- reference: 'storageSelector',
+ reference: 'fleecingStorage',
clusterView: true,
storageContent: 'images',
allowBlank: false,
disabled: true,
- bind: {
- disabled: '{!fleecingEnabled.checked}',
- },
},
endFlex: 2,
endColumn: {
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-23 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 12:14 [pve-devel] [PATCH manager 1/2] ui: backup jobs: fix fleecing parameters for 'run now' button Dominik Csapak
2024-04-23 12:15 ` Dominik Csapak [this message]
2024-04-23 13:16 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423121500.2460620-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox