[pve-devel] [PATCH manager 1/2] ui: backup jobs: fix fleecing parameters for 'run now' button

[pve-devel] [PATCH manager 1/2] ui: backup jobs: fix fleecing parameters for 'run now' button

[Dominik Csapak]

we have to 'printPropertyString' the fleecing parameters, otherwise
we'll get api parameter errors for that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/Backup.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 336b23f5..4ba80b31 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -617,7 +617,7 @@ Ext.define('PVE.dc.BackupView', {
 	    delete job['repeat-missed'];
 	    job.all = job.all === true ? 1 : 0;
 
-	    ['performance', 'prune-backups'].forEach(key => {
+	    ['performance', 'prune-backups', 'fleecing'].forEach(key => {
 		if (job[key]) {
 		    job[key] = PVE.Parser.printPropertyString(job[key]);
 		}
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] ui: backup job editor: fix disable behavior for fleecing storage

[Dominik Csapak]

commit
569b0388 (ui: fix reset behavior of backup job editor)

disabled the fleecint storage field by default (as that is the default
state) to fix the reset behavior. This broke editing the job when
fleecing was enabled and the user did not navigate to the advanced tab
yet.

It seems that the 'bind' here only gets triggered once the panel is
rendered, but we actually need it before that.

To work around the issue for now, manually enable/disable the field when
toggling the fleecing checkbox. (Though this warrants a bit of deeper
investigation into this bind behavior)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/panel/BackupAdvancedOptions.js | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index f1810637..650946fe 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -18,6 +18,17 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 
     controller: {
 	xclass: 'Ext.app.ViewController',
+
+	toggleFleecing: function(cb, value) {
+	    let me = this;
+	    me.lookup('fleecingStorage').setDisabled(!value);
+	},
+
+	control: {
+	    'proxmoxcheckbox[reference=fleecingEnabled]': {
+		change: 'toggleFleecing',
+	    },
+	}
     },
 
     onGetValues: function(formValues) {
@@ -181,14 +192,11 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 		xtype: 'pveStorageSelector',
 		name: 'fleecing-storage',
 		fieldLabel: gettext('Fleecing Storage'),
-		reference: 'storageSelector',
+		reference: 'fleecingStorage',
 		clusterView: true,
 		storageContent: 'images',
 		allowBlank: false,
 		disabled: true,
-		bind: {
-		    disabled: '{!fleecingEnabled.checked}',
-		},
 	    },
 	    endFlex: 2,
 	    endColumn: {
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 1/2] ui: backup jobs: fix fleecing parameters for 'run now' button

[Thomas Lamprecht]

Am 23/04/2024 um 14:14 schrieb Dominik Csapak:
> we have to 'printPropertyString' the fleecing parameters, otherwise
> we'll get api parameter errors for that
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/dc/Backup.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied both patches, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel