public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexander Zeidler <a.zeidler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] report: fix regex of config filenames
Date: Thu, 18 Apr 2024 09:44:04 +0200	[thread overview]
Message-ID: <20240418074406.22025-2-a.zeidler@proxmox.com> (raw)

to only match those that are correct/accepted by their software

Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
 PVE/Report.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index 9c46aa9b..53ffdcbb 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -35,8 +35,8 @@ my $init_report_cmds = sub {
 		'cat /etc/hosts',
 		'pvesubscription get',
 		'cat /etc/apt/sources.list',
-		sub { dir2text('/etc/apt/sources.list.d/', '.*list') },
-		sub { dir2text('/etc/apt/sources.list.d/', '.*sources') },
+		sub { dir2text('/etc/apt/sources.list.d/', '.+\.list') },
+		sub { dir2text('/etc/apt/sources.list.d/', '.+\.sources') },
 		'lscpu',
 		'pvesh get /cluster/resources --type node --output-format=yaml',
 	    ],
@@ -64,9 +64,9 @@ my $init_report_cmds = sub {
 	    order => 40,
 	    cmds => [
 		'qm list',
-		sub { dir2text('/etc/pve/qemu-server/', '\d.*conf') },
+		sub { dir2text('/etc/pve/qemu-server/', '\d+\.conf') },
 		'pct list',
-		sub { dir2text('/etc/pve/lxc/', '\d.*conf') },
+		sub { dir2text('/etc/pve/lxc/', '\d+\.conf') },
 	    ],
 	},
 	network => {
@@ -83,7 +83,7 @@ my $init_report_cmds = sub {
 	firewall => {
 	    order => 50,
 	    cmds => [
-		sub { dir2text('/etc/pve/firewall/', '.*fw') },
+		sub { dir2text('/etc/pve/firewall/', '.+\.fw') },
 		'cat /etc/pve/local/host.fw',
 		'iptables-save -c | column -t -l4 -o" "',
 	    ],
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2024-04-18  7:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  7:44 Alexander Zeidler [this message]
2024-04-18 20:28 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418074406.22025-2-a.zeidler@proxmox.com \
    --to=a.zeidler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal