From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 container 2/3] pct: fsck: also unmap when fsck command failed
Date: Fri, 12 Apr 2024 13:08:13 +0200 [thread overview]
Message-ID: <20240412110814.46684-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20240412110814.46684-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
New in v2.
src/PVE/CLI/pct.pm | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 513bcba..13aa4c1 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
@@ -299,9 +299,13 @@ __PACKAGE__->register_method ({
}
push(@$command, $path);
- PVE::Tools::run_command($command);
+ eval { PVE::Tools::run_command($command); };
+ my $err = $@;
- PVE::Storage::unmap_volume($storage_cfg, $volid) if $storage_id;
+ eval { PVE::Storage::unmap_volume($storage_cfg, $volid) if $storage_id; };
+ warn $@ if $@;
+
+ die $err if $err;
};
PVE::LXC::Config->lock_config($vmid, $do_fsck);
--
2.39.2
next prev parent reply other threads:[~2024-04-12 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 11:08 [pve-devel] [PATCH-SERIES v2 container] add missing volume activation for hotplug and fsck Fiona Ebner
2024-04-12 11:08 ` [pve-devel] [PATCH v2 container 1/3] mountpoint mount: activate PVE-managed volumes during preparation Fiona Ebner
2024-04-12 11:08 ` Fiona Ebner [this message]
2024-04-12 11:08 ` [pve-devel] [PATCH v2 container 3/3] pct: fsck: add missing call to activate volume Fiona Ebner
2024-04-12 12:09 ` [pve-devel] applied-series: [PATCH-SERIES v2 container] add missing volume activation for hotplug and fsck Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412110814.46684-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox