From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager v4 3/6] sdn: qinq: vlan: properly validate bridge name
Date: Fri, 12 Apr 2024 10:07:34 +0200 [thread overview]
Message-ID: <20240412080737.34521-4-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20240412080737.34521-1-s.hanreich@proxmox.com>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
www/manager6/sdn/zones/QinQEdit.js | 3 +++
www/manager6/sdn/zones/VlanEdit.js | 3 +++
2 files changed, 6 insertions(+)
diff --git a/www/manager6/sdn/zones/QinQEdit.js b/www/manager6/sdn/zones/QinQEdit.js
index 795ff9dfd..de177d7cb 100644
--- a/www/manager6/sdn/zones/QinQEdit.js
+++ b/www/manager6/sdn/zones/QinQEdit.js
@@ -24,6 +24,9 @@ Ext.define('PVE.sdn.zones.QinQInputPanel', {
name: 'bridge',
fieldLabel: 'Bridge',
allowBlank: false,
+ vtype: 'BridgeName',
+ minLength: 1,
+ maxLength: 10,
},
{
xtype: 'proxmoxintegerfield',
diff --git a/www/manager6/sdn/zones/VlanEdit.js b/www/manager6/sdn/zones/VlanEdit.js
index 23530bfcf..7f7ccca41 100644
--- a/www/manager6/sdn/zones/VlanEdit.js
+++ b/www/manager6/sdn/zones/VlanEdit.js
@@ -24,6 +24,9 @@ Ext.define('PVE.sdn.zones.VlanInputPanel', {
name: 'bridge',
fieldLabel: 'Bridge',
allowBlank: false,
+ vtype: 'BridgeName',
+ minLength: 1,
+ maxLength: 10,
},
];
--
2.39.2
next prev parent reply other threads:[~2024-04-12 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:07 [pve-devel] [PATCH common/docs/firewall/manager/proxmox-widget-toolkit v4 0/6] drop vmbr prefix for bridges Stefan Hanreich
2024-04-12 8:07 ` [pve-devel] [PATCH pve-common v4 1/6] fix #545: interfaces: allow arbitrary bridge names in network config Stefan Hanreich
2024-04-12 8:07 ` [pve-devel] [PATCH pve-docs v4 2/6] network: update specification for bridge names Stefan Hanreich
2024-04-12 8:07 ` Stefan Hanreich [this message]
2024-04-12 8:07 ` [pve-devel] [PATCH pve-manager v4 4/6] sdn: vlan: fix indentation in vlan edit dialogue Stefan Hanreich
2024-04-12 8:07 ` [pve-devel] [PATCH pve-firewall v4 5/6] simulator: use new bridge naming scheme Stefan Hanreich
2024-04-12 8:07 ` [pve-devel] [PATCH proxmox-widget-toolkit v4 6/6] network: allow bridges to have any valid interface name Stefan Hanreich
2024-04-21 12:19 ` [pve-devel] applied-series: [PATCH common/docs/firewall/manager/proxmox-widget-toolkit v4 0/6] drop vmbr prefix for bridges Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412080737.34521-4-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox