From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC qemu-server/pve-container/.. 0/19] pool resource limits
Date: Wed, 10 Apr 2024 15:12:57 +0200 [thread overview]
Message-ID: <20240410131316.1208679-1-f.gruenbichler@proxmox.com> (raw)
high level description:
VM/CT vmstatus returns new fields for configured and running "usage"
values, these are then broadcasted by pvestatd on each node via KV.
helpers in guest-common to check those limits
pool API returns limits and usage, them and allows setting the limits
qemu-server/pve-container try to check actions against those limits.
since the broadcast is async, there is always an opportunity to cheat by
racing against the broadcast. this is unavoidable unless we want to
serialize all usage affecting tasks across the cluster..
TODOs (but sent this anyway to get feedback for the basic concept):
- disk limits/usage
- fill in missing edge cases (I am sure there are some)
- RRD/metrics support (or even switching entirely to RRD based
broadcasting instead of KV)
- timeout of broadcasted data if node goes offline/stops broadcasting
- actual GUI
- ... ?
I haven't tested the pve-container changes much, there might be missing
parts and dragons there, although it mostly follows the qemu-server
changes.
interdependencies:
- pve-guest-common needs pve-access-control
- pve-manager needs pve-access-control and pve-guest-common
- qemu-server/pve-container need pve-guest-common
pve-access-control:
Fabian Grünbichler (1):
pools: define resource limits
src/PVE/AccessControl.pm | 42 +++++++++++++++++++++++++++++++++++++--
src/test/parser_writer.pl | 14 ++++++-------
2 files changed, 47 insertions(+), 9 deletions(-)
pve-guest-common:
Fabian Grünbichler (1):
helpers: add pool limit/usage helpers
src/PVE/GuestHelpers.pm | 190 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 190 insertions(+)
pve-manager:
Fabian Grünbichler (4):
api: pools: add limits management
pvestatd: collect and broadcast pool usage
api: return pool usage when queried
ui: add pool limits and usage
PVE/API2/Pool.pm | 51 +++++++++++++++++++++++++---
PVE/Service/pvestatd.pm | 59 ++++++++++++++++++++++++++++++---
www/manager6/pool/StatusView.js | 33 ++++++++++++++++++
3 files changed, 135 insertions(+), 8 deletions(-)
pve-container:
Fabian Grünbichler (7):
config: add pool usage helper
status: add pool usage fields
create/restore/clone: handle pool limits
start: handle pool limits
hotplug: handle pool limits
rollback: handle pool limits
update: handle pool limits
src/PVE/API2/LXC.pm | 25 +++++++++++++++++++
src/PVE/API2/LXC/Config.pm | 21 ++++++++++++++++
src/PVE/API2/LXC/Snapshot.pm | 7 ++++++
src/PVE/LXC.pm | 37 +++++++++++++++++++++++++++
src/PVE/LXC/Config.pm | 48 ++++++++++++++++++++++++++++++++++++
5 files changed, 138 insertions(+)
qemu-server:
Fabian Grünbichler (6):
config: add pool usage helper
vmstatus: add usage values for pool limits
create/restore/clone: handle pool limits
update/hotplug: handle pool limits
start: handle pool limits
rollback: handle pool limits
PVE/API2/Qemu.pm | 54 ++++++++++++++++++++++++++++++++++++++++
PVE/QemuConfig.pm | 30 ++++++++++++++++++++++
PVE/QemuServer.pm | 49 ++++++++++++++++++++++++++++++++++++
PVE/QemuServer/Memory.pm | 6 +++++
4 files changed, 139 insertions(+)
--
2.39.2
next reply other threads:[~2024-04-10 13:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 13:12 Fabian Grünbichler [this message]
2024-04-10 13:12 ` [pve-devel] [PATCH access-control 1/1] pools: define " Fabian Grünbichler
2024-04-10 13:12 ` [pve-devel] [PATCH container 1/7] config: add pool usage helper Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH container 2/7] status: add pool usage fields Fabian Grünbichler
2024-04-11 9:28 ` Wolfgang Bumiller
2024-04-15 9:32 ` Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH container 3/7] create/restore/clone: handle pool limits Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH container 4/7] start: " Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH container 5/7] hotplug: " Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH container 6/7] rollback: " Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH container 7/7] update: " Fabian Grünbichler
2024-04-11 7:23 ` Fabian Grünbichler
2024-04-11 10:03 ` Wolfgang Bumiller
2024-04-15 9:35 ` Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH guest-common 1/1] helpers: add pool limit/usage helpers Fabian Grünbichler
2024-04-11 9:17 ` Wolfgang Bumiller
2024-04-15 9:38 ` Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH manager 1/4] api: pools: add limits management Fabian Grünbichler
2024-04-11 9:24 ` Wolfgang Bumiller
2024-04-10 13:13 ` [pve-devel] [PATCH manager 2/4] pvestatd: collect and broadcast pool usage Fabian Grünbichler
2024-04-11 9:32 ` Wolfgang Bumiller
2024-04-15 12:36 ` Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH manager 3/4] api: return pool usage when queried Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH manager 4/4] ui: add pool limits and usage Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH qemu-server 1/6] config: add pool usage helper Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH qemu-server 2/6] vmstatus: add usage values for pool limits Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH qemu-server 3/6] create/restore/clone: handle " Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH qemu-server 4/6] update/hotplug: " Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH qemu-server 5/6] start: " Fabian Grünbichler
2024-04-10 13:13 ` [pve-devel] [PATCH qemu-server 6/6] rollback: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410131316.1208679-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox