public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Lendl <s.lendl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: use PSS instead of RSZ for caluculating memory usage
Date: Mon,  8 Apr 2024 15:25:53 +0200	[thread overview]
Message-ID: <20240408132552.293049-2-s.lendl@proxmox.com> (raw)

PSS properly accounts for memory usage of shared libraries and is
therefore better suited when summing up memory usage of multiple
processes.

Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
---
 debian/patches/series                      |  1 +
 debian/patches/use-pss-instead-of-rsz.diff | 11 +++++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 debian/patches/use-pss-instead-of-rsz.diff

diff --git a/debian/patches/series b/debian/patches/series
index 24e8678..1bdac37 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ init-script.diff
 ksmtuned.diff
 adjust-ksm-slepp.diff
 awk-printf.diff
+use-pss-instead-of-rsz.diff
diff --git a/debian/patches/use-pss-instead-of-rsz.diff b/debian/patches/use-pss-instead-of-rsz.diff
new file mode 100644
index 0000000..885bf30
--- /dev/null
+++ b/debian/patches/use-pss-instead-of-rsz.diff
@@ -0,0 +1,11 @@
+--- ksm-control-scripts/ksmtuned	2024-04-08 15:10:04.218449486 +0200
++++ ksm-control-scripts.new/ksmtuned	2024-04-08 15:10:16.214620527 +0200
+@@ -72,7 +72,7 @@
+     # calculate how much memory is committed to running qemu processes
+     local progname
+     progname=${1:-kvm}
+-    ps -C "$progname" -o rsz | awk '{ sum += $1 }; END { printf ("%.0f", sum) }'
++    ps -C "$progname" -o pss= | awk '{ sum += $1 }; END { printf ("%.0f", sum) }'
+ }
+ 
+ free_memory () {
-- 
2.44.0





             reply	other threads:[~2024-04-08 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 13:25 Stefan Lendl [this message]
2024-04-08 15:36 ` [pve-devel] applied: " Thomas Lamprecht
     [not found] ` <bbfc1739-4324-4795-9c97-dc069821c83e@web.de>
2024-04-17 15:00   ` [pve-devel] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408132552.293049-2-s.lendl@proxmox.com \
    --to=s.lendl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal