From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v5 pve-storage, pve-manager 00/11] Fix #4759: Configure Permissions for ceph-crash.service
Date: Tue, 2 Apr 2024 16:55:12 +0200 [thread overview]
Message-ID: <20240402145523.683008-1-m.carrara@proxmox.com> (raw)
Fix #4759: Configure Permissions for ceph-crash.service - Version 5
===================================================================
Notable changes since v4
------------------------
* The patches regarding Ceph Reef and Ceph Quincy have been applied in
v4 and are thus dropped from this series (thanks Thomas!)
* The tests for both the parser and the writer are rewritten, making
them independent of one another
* Many additional test cases
* New test subroutine that compares each test case against Ceph's
`ceph-conf` CLI in order to preemptively detect changes / regressions
in Ceph's config file format
- In total, there are now 37 test cases, each tested against 3
testing subroutines, making 111 tests in total
* The Ceph config writer now correctly escapes all un-escaped comment
literals
* The Ceph config parser is completely rewritten, making its
implementation almost fully equivalent to Ceph's original parser
* Suppress warning messages while running `postinst` of 'pve-manager'
(thanks Friedrich!)
* Prevent `deb-systemd-invoke` from failing (thanks Fabian!)
For a detailed list of changes, please see the comments in the in the
individual patches.
Post-Installation Version Guard
-------------------------------
The call to the new function in the `postinst` hook, which is introduced
in patch 09, now uses '0.0.0' as placeholder in its version guard.
When applying this series, this placeholder must be replaced with the
next expected version of the 'pve-manager' package in order to run the
Ceph configuration helper during users' next update (patches 09, 10).
Older Versions
--------------
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061546.html
v2: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061646.html
v3: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061802.html
v4: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062093.html
Summary of Changes
------------------
pve-storage:
Max Carrara (8):
cephconfig: change code style inside config writer
test: add tests for 'ceph.conf' parser and writer
test: cephconfig: add regression test for Ceph config parser & writer
cephconfig: allow writing arbitrary sections
cephconfig: change order of written sections
cephconfig: align written key-value pairs by tab
cephconfig: escape un-escaped comment literals on write
cephconfig: align our parser with Ceph's parser
debian/control | 1 +
src/Makefile | 1 +
src/PVE/CephConfig.pm | 282 +++++-
src/PVE/Makefile | 4 +
src/PVE/test/Makefile | 9 +
src/PVE/test/ceph_conf_parse_write_test.pl | 1035 ++++++++++++++++++++
6 files changed, 1305 insertions(+), 27 deletions(-)
create mode 100644 src/PVE/test/Makefile
create mode 100755 src/PVE/test/ceph_conf_parse_write_test.pl
pve-manager:
Max Carrara (3):
ceph: introduce '/etc/pve/ceph'
fix #4759: ceph: configure ceph-crash.service and its key
bin/make: gather helper scripts in separate variable
PVE/API2/Ceph.pm | 5 ++
PVE/API2/Ceph/MON.pm | 8 +++
PVE/Ceph/Tools.pm | 47 ++++++++++++-
bin/Makefile | 6 +-
bin/pve-init-ceph-crash | 142 ++++++++++++++++++++++++++++++++++++++++
debian/postinst | 25 +++++++
6 files changed, 230 insertions(+), 3 deletions(-)
create mode 100755 bin/pve-init-ceph-crash
--
2.39.2
next reply other threads:[~2024-04-02 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 14:55 Max Carrara [this message]
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 01/11] cephconfig: change code style inside config writer Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 02/11] test: add tests for 'ceph.conf' parser and writer Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 03/11] test: cephconfig: add regression test for Ceph config parser & writer Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 04/11] cephconfig: allow writing arbitrary sections Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 05/11] cephconfig: change order of written sections Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 06/11] cephconfig: align written key-value pairs by tab Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 07/11] cephconfig: escape un-escaped comment literals on write Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-storage 08/11] cephconfig: align our parser with Ceph's parser Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-manager 09/11] ceph: introduce '/etc/pve/ceph' Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-manager 10/11] fix #4759: ceph: configure ceph-crash.service and its key Max Carrara
2024-04-02 14:55 ` [pve-devel] [PATCH v5 pve-manager 11/11] bin/make: gather helper scripts in separate variable Max Carrara
2024-04-09 9:48 ` [pve-devel] [PATCH v5 pve-storage, pve-manager 00/11] Fix #4759: Configure Permissions for ceph-crash.service Maximiliano Sandoval
2024-04-09 9:55 ` Maximiliano Sandoval
2024-04-09 10:28 ` Max Carrara
2024-04-10 11:45 ` Friedrich Weber
2024-04-11 12:59 ` [pve-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402145523.683008-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox