From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py
Date: Fri, 22 Mar 2024 19:06:17 +0100 [thread overview]
Message-ID: <20240322180624.441185-1-m.carrara@proxmox.com> (raw)
Improve listvms.py - Version 2
==============================
Notable Changes Since v1
------------------------
* mypy [0] is now a build dependency and runs automatically on
`make install` (and thus also on `make deb` etc.)
* JSON output is now directly streamed to stdout via `json.dump()`
instead of creating and printing a string
For a detailed list of changes, please see the comments in the
invididual patches.
Older Versions
--------------
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062258.html
References
----------
[0]: https://www.mypy-lang.org/
Summary of Changes
------------------
Max Carrara (7):
listvms: remove unused import and variable
listvms: reorder imports
listvms: improve typing and add dataclasses to represent dicts
listvms: add arg parser, context manager for connections, fetch helper
listvms: dump json directly to stdout
listvms: run formatter
use mypy for automatic type checks in Python
Makefile | 13 ++-
debian/control | 1 +
listvms.py | 300 +++++++++++++++++++++++++++++++++++++------------
mypy.ini | 8 ++
4 files changed, 247 insertions(+), 75 deletions(-)
create mode 100644 mypy.ini
--
2.39.2
next reply other threads:[~2024-03-22 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 18:06 Max Carrara [this message]
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 1/7] listvms: remove unused import and variable Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 2/7] listvms: reorder imports Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 3/7] listvms: improve typing and add dataclasses to represent dicts Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 4/7] listvms: add arg parser, context manager for connections, fetch helper Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 5/7] listvms: dump json directly to stdout Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 6/7] listvms: run formatter Max Carrara
2024-03-22 18:06 ` [pve-devel] [PATCH v2 pve-esxi-import-tools 7/7] use mypy for automatic type checks in Python Max Carrara
2024-03-27 10:50 ` [pve-devel] applied-series: [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322180624.441185-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox