From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 2/2] ceph: mon: adapt code style in mon removal assertion
Date: Wed, 13 Mar 2024 15:53:45 +0100 [thread overview]
Message-ID: <20240313145345.484627-2-m.carrara@proxmox.com> (raw)
In-Reply-To: <20240313145345.484627-1-m.carrara@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
PVE/API2/Ceph/MON.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index 1737c294..f13115a0 100644
--- a/PVE/API2/Ceph/MON.pm
+++ b/PVE/API2/Ceph/MON.pm
@@ -148,13 +148,13 @@ my $assert_mon_can_remove = sub {
my ($monhash, $monlist, $monid, $mondir) = @_;
if (!(defined($monhash->{$monid}) ||
- grep { exists($_->{name}) && $_->{name} eq $monid } @$monlist))
+ grep { exists($_->{name}) && $_->{name} eq $monid } $monlist->@*))
{
die "no such monitor id '$monid'\n"
}
die "monitor filesystem '$mondir' does not exist on this node\n" if ! -d $mondir;
- die "can't remove last monitor\n" if scalar(@$monlist) <= 1;
+ die "can't remove last monitor\n" if scalar($monlist->@*) <= 1;
};
my $remove_addr_from_mon_host = sub {
--
2.39.2
next prev parent reply other threads:[~2024-03-13 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 14:53 [pve-devel] [PATCH pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check " Max Carrara
2024-03-13 14:53 ` Max Carrara [this message]
2024-03-13 15:42 ` Stefan Sterz
2024-03-14 7:56 ` Fiona Ebner
2024-03-14 9:34 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313145345.484627-2-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox