[pve-devel] [PATCH manager] fix #5293: ceph status: fix division-by-zero when calculating usage

[pve-devel] [PATCH manager] fix #5293: ceph status: fix division-by-zero when calculating usage

[Christoph Heiss]

Fixes #5293 [0]. This happens when no OSDs are created yet and thus the
total space is 0, which leads to a division-by-zero.

Add a simple check if the total space is greater than 0.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5293

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 www/manager6/ceph/Status.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
index 32be91ac7..72b3c990d 100644
--- a/www/manager6/ceph/Status.js
+++ b/www/manager6/ceph/Status.js
@@ -346,7 +346,8 @@ Ext.define('PVE.node.CephStatus', {
 	);
 
 	// update the usage widget
-	me.down('#space').updateValue(used/total, text);
+	const usage = total > 0 ? used / total : 0;
+	me.down('#space').updateValue(usage, text);
 
 	let readiops = pgmap.read_op_per_sec;
 	let writeiops = pgmap.write_op_per_sec;
-- 
2.43.1

[pve-devel] applied: [PATCH manager] fix #5293: ceph status: fix division-by-zero when calculating usage

[Thomas Lamprecht]

On 12/03/2024 10:13, Christoph Heiss wrote:
> Fixes #5293 [0]. This happens when no OSDs are created yet and thus the
> total space is 0, which leads to a division-by-zero.
> 
> Add a simple check if the total space is greater than 0.
> 
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5293
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  www/manager6/ceph/Status.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!