public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager] node: use configured proxy for https when downloading files
Date: Fri,  8 Mar 2024 13:35:35 +0100	[thread overview]
Message-ID: <20240308123535.1500-1-h.laimer@proxmox.com> (raw)

... for both the downloading itself and the 'Query URL' part

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 PVE/API2/Nodes.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index cc5ee65e..b35e042d 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1605,6 +1605,7 @@ __PACKAGE__->register_method({
 		sha512sum => $appliance->{sha512sum},
 		md5sum => $appliance->{md5sum},
 		http_proxy => $dccfg->{http_proxy},
+		https_proxy => $dccfg->{http_proxy},
 	    });
 	};
 
@@ -1671,6 +1672,7 @@ __PACKAGE__->register_method({
 	my $dccfg = PVE::Cluster::cfs_read_file('datacenter.cfg');
 	if ($dccfg->{http_proxy}) {
 	    $ua->proxy('http', $dccfg->{http_proxy});
+	    $ua->proxy('https', $dccfg->{http_proxy});
 	}
 
 	my $verify = $param->{'verify-certificates'} // 1;
-- 
2.39.2





                 reply	other threads:[~2024-03-08 12:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308123535.1500-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal