From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section
Date: Wed, 28 Feb 2024 20:03:08 +0100 [thread overview]
Message-ID: <20240228200308.4a2f8c35@rosa.proxmox.com> (raw)
In-Reply-To: <20240228180828.1412762-1-c.heiss@proxmox.com>
Thanks for the catch and fix! applied it!
(nit: pmg-devel@list.proxmox.com is preferred for pmg-docs patches)
On Wed, 28 Feb 2024 19:08:21 +0100
Christoph Heiss <c.heiss@proxmox.com> wrote:
> That slipped through, asciidoc uses 4 not 3 dashes for that.
>
> Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation")
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> pmg-installation.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pmg-installation.adoc b/pmg-installation.adoc
> index 326fe5b..25d16a7 100644
> --- a/pmg-installation.adoc
> +++ b/pmg-installation.adoc
> @@ -284,9 +284,9 @@ ZFS can use a dedicated drive as write cache, called the ZFS Intent Log (ZIL).
> Use a fast drive (SSD) for it. It can be added after installation with the
> following command:
>
> ----
> +----
> # zpool add <pool-name> log </dev/path_to_fast_ssd>
> ----
> +----
>
> Adding the `nomodeset` Kernel Parameter
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2024-02-28 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 18:08 [pve-devel] " Christoph Heiss
2024-02-28 19:03 ` Stoiko Ivanov [this message]
2024-02-29 9:05 ` [pve-devel] applied: " Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228200308.4a2f8c35@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox