From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit
Date: Fri, 23 Feb 2024 13:03:39 +0100 [thread overview]
Message-ID: <20240223120339.15726-1-h.laimer@proxmox.com> (raw)
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
came up in enterprise support, and I don't think there is a reason to
not have it in the UI, while having it in the API
v2:
- use Aaron's improved help text
www/manager6/storage/DirEdit.js | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 3e2025fc..4d1921dc 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
},
];
+ me.advancedColumn2 = [
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'is_mountpoint',
+ uncheckedValue: 0,
+ fieldLabel: gettext('Mountpoint'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted.'),
+ },
+ },
+ ];
me.callParent();
},
});
--
2.39.2
next reply other threads:[~2024-02-23 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:03 Hannes Laimer [this message]
2024-04-15 13:10 ` Fiona Ebner
2024-04-15 14:02 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223120339.15726-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox